-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receive password prompt when hovering over line which contains password
#65
Comments
Thanks for the bug report. Fixed in 0.8.6 |
Hmm I wonder if there is a larger issue here - it feels like the line of text in the buffer is getting interpreted by emacs/async etc in some way - I wonder if it is possible to get command execution via an untrusted buffer through this issue? Whilst the current fix stops async prompting for a password, I fear async may be invoking |
I agree - though I'm not proficient enough in Elisp to understand what's going on, I don't feel like the proposed fix of setting |
I couldn't find any code from the emacs-async package that interprets the result buffer as code. It looks like there is a simple regexp that checks if the output of a command matches the |
ah ok - thanks - yep I agree, the input string is not actually interpreted in anyway - just matched against - so there doesn't appear to be any risk here of command injection etc. Thanks for clarifying this for me and your work on blamer @Artawower. |
When hovering a line that is part of a commit and includes the word
password
(not sure of the exact heuristic), I receive a password prompt.This only happens when
blamer-enable-async-execution-p
is set tot
.Can replicate by having a committed line with the following contents:
The text was updated successfully, but these errors were encountered: