Use getSafeProperty in help

AlexanderBeyn · Jun 30, 2017 · 485cb88 · 485cb88
1 parent 142e200
commit 485cb88
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/expression/function/help.js b/lib/expression/function/help.js
@@ -1,5 +1,7 @@
 'use strict';
 
+var getSafeProperty = require('../../utils/customs').getSafeProperty;
+
 function factory (type, config, load, typed, math) {
   var docs = load(require('../docs'));
 
@@ -50,7 +52,7 @@ function factory (type, config, load, typed, math) {
          */
       }
 
-      var doc = docs[name];
+      var doc = getSafeProperty(docs, name);
       if (!doc) {
         throw new Error('No documentation found on "' + name + '"');
       }

diff --git a/test/expression/function/help.test.js b/test/expression/function/help.test.js
@@ -45,6 +45,10 @@ describe('help', function() {
     assert.equal(help.doc.name, 'pi');
   });
 
+  it('should not allow accessing unsafe properties ', function() {
+    assert.throws(function () {math.help('constructor')}, /No access/);
+  });
+
   it('should throw an error when no help is found', function() {
     // assert.throws(function () {math.help(undefined)}, /No documentation found/);
     assert.throws(function () {math.help(new Date())}, /No documentation found/);