Copy packets to prevent AddressSanitizer: stack-use-after-return on address #2911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the "Address Sanitizer" with the "Detect use of stack after return" feature has exposed a stack-use-after-return issue in the following code example:
This pull request copies all MIDIPacket instead of iterating them one by one and fixes the issue with address sanitizer.
Please discuss if this is a good idea.