User talk:Σ/Archive/2018/December

Hey Sigma, I was working on SQL queries and I used your site (summary.py) to compare the results but that's not the subject of my message... I noticed that your site and my requests were not giving the last results of the last few hours. By talking with another Wikipedian, we found T166733. The comment_text of the revisions are now stored in the comment table since today, identifiable by their id.

So, the search for contributions based on a word in a comment can no longer work if the old model is used. Here is the structure of the new table to use:

Hoping to have been as clear as possible, regards, Lofhi (talk) 21:18, 25 October 2018 (UTC)

Thanks for the notice @Lofhi:. The SQL query that the edit summary search tool currently uses is:

SELECT rr.rev_parent_id,r.rev_id,r.rev_timestamp,r.rev_minor_edit,r.rev_comment,rr.rev_len,r.rev_len,page_title,page_namespace,page_latest
FROM revision_userindex r JOIN page ON rev_page=page_id
LEFT JOIN revision_userindex rr ON r.rev_parent_id=rr.rev_id
WHERE r.rev_user_text=%s
AND r.rev_deleted=0
AND CONVERT(r.rev_comment USING utf8mb4) LIKE %s
ORDER BY r.rev_timestamp DESC
LIMIT %s

(view the page source and scroll to the bottom, e.g. here). Can you give an example as to what the new query should look like? →Σσς. (Sigma) 22:15, 29 October 2018 (UTC)

So, rev_comment is deprecated. The first solution (maybe not the best) I see is to do an INNER JOIN comment com ON r.rev_id = com.comment_id and use com.comment_text to get the editing comment. But you should prefer to wait before modifying anything, it's indicated on Phabricator that the enwiki migration alone would take about 3 weeks. I think people can wait, unless you have time to add the checking of both tables until the migration of all projects is complete. Lofhi (talk) 01:12, 1 November 2018 (UTC)

INNER JOIN comment com ON r.rev_comment_id = com.comment_id would be the correct join in Toolforge. Also, BTW, the migration has completed processing of enwiki's revision table already. Now it's working through the archive table, and there are 7 more to do after that. Anomie⚔ 17:10, 6 November 2018 (UTC)

Oops! Thank you for the correction Anomie. Apparently everything will be done within a week. Lofhi (talk) 20:20, 7 November 2018 (UTC)

Per phab:T166733 it looks like the backfilling of the table is complete, and so the the new table can be used solely. Σ, could you update the query? Thanks. Galobtter (pingó mió) 08:28, 16 November 2018 (UTC)

Fixed now. →Σσς. (Sigma) 19:11, 24 November 2018 (UTC)

Thanks! Galobtter (pingó mió) 19:16, 24 November 2018 (UTC)

The comments don't appear if I do a stupid search on my username. =( Lofhi (talk) 21:26, 24 November 2018 (UTC)

@Anomie: For future migrations, I think the standard practice is to make it write to both the old and the new tables at once, while migrating the old table's data to the new table in the background. This updating of the old table should happen until the entire old table's history is fully migrated to the new table, at which point only then should you stop updating the old one. Otherwise, we end up with a situation like this. →Σσς. (Sigma) 00:55, 25 November 2018 (UTC)

I don't think there is a standard practice. Both methods have advantages and drawbacks. Anomie⚔ 14:16, 25 November 2018 (UTC)

You also have two other tools named "Pages created" and "User contribution search". Those tools also need to be updated to use the new comment table. Also, judging from this query, many revisions from the end of February to October 25 still have both a rev_comment_id and a non-empty rev_comment. We should start blanking out the remaining rev_comment fields that still have not been blanked yet. Merry Christmas and Happy New Year, GeoffreyT2000 (talk) 00:49, 2 December 2018 (UTC)

This request to blank out all remaining rev_comment fields is now tracked at phab:T210935. Merry Christmas and Happy New Year, GeoffreyT2000 (talk) 01:03, 2 December 2018 (UTC)

The edit summary search tool is inaccurate and doesn't show complete results. Like for example, searching my summaries for "Adding new report for" only shows the latest on October 22, 2018, but I've been using that summary a lot since then like minutes ago I used it for an SPI report but it's not showing in the tool. Flooded with them hundreds 18:08, 20 November 2018 (UTC)

Flooded with them hundreds, see #Tools_wmflabs above Galobtter (pingó mió) 09:56, 21 November 2018 (UTC)

I have made a fork of your archiver script to allow me to use it on my sandbox page (i'd like to remember what I messed around with, in case its ever useful in the future). I am not asking for help archiving my page, but just wanted to let you know and to thank you for the script. You can see my version at User:DannyS712/ArchiveUser.js. --DannyS712 (talk) 11:28, 26 November 2018 (UTC)

  Note: I have also requested that xtools' autoedits regex for OneClickArchiver be updated to include edits made by both your script, and mine, as well as link to your page. Please let me know if that was out of line, and see the phab request here. --DannyS712 (talk) 04:58, 15 December 2018 (UTC)