| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: warning: comparison of integer expressions of different signedness related to simd.h |
| Date: | 2022-09-03 05:57:32 |
| Message-ID: | 1311246.1662184652@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> /usr/local/pgsql/master/include/server/port/simd.h: In function ‘vector8_has’:
>> /usr/local/pgsql/master/include/server/port/simd.h:168:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
>> 168 | for (int i = 0; i < sizeof(Vector8); i++)
> "int" should probably be "Size" -- does that remove the warning?
Agreed, should be Size or size_t, or else cast the sizeof() result.
But I wonder why none of the buildfarm is showing such a warning.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2022-09-03 06:02:02 | Re: warning: comparison of integer expressions of different signedness related to simd.h |
| Previous Message | Pavel Stehule | 2022-09-03 05:53:52 | Re: warning: comparison of integer expressions of different signedness related to simd.h |