| From: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] crashes in RestoreSnapshot on hot standby |
| Date: | 2016-07-01 05:41:20 |
| Message-ID: | 87k2h5synz.fsf@credativ.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila writes:
> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> Or maybe just like this?
>>
>> - snapshot->subxip = snapshot->xip + serialized_snapshot->xcnt;
>> + snapshot->subxip = ((TransactionId *) (snapshot + 1)) +
>> + serialized_snapshot->xcnt;
>>
>
> This way it looks better to me. Thanks for the patch.
I no longer see these crashes when testing with the patch applied.
thanks,
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-07-01 06:40:00 | Re: Is a UDF binary portable across different minor releases and PostgreSQL distributions? |
| Previous Message | Pavel Stehule | 2016-07-01 05:02:25 | Re: Forthcoming SQL standards about JSON and Multi-Dimensional Arrays (FYI) |