| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: TABLESAMPLE patch |
| Date: | 2015-04-06 18:02:41 |
| Message-ID: | 5522CA41.3090606@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/04/15 14:30, Petr Jelinek wrote:
> On 06/04/15 11:02, Simon Riggs wrote:
>
>> Are we ready for a final detailed review and commit?
>>
>
> I plan to send v12 in the evening with some additional changes that came
> up from Amit's comments + some improvements to error reporting. I think
> it will be ready then.
>
Ok so here it is.
Changes vs v11:
- changed input parameter list to expr_list
- improved error reporting, particularly when input parameters are wrong
- fixed SELECT docs to show correct syntax and mention that there can be
more sampling methods
- added name of the sampling method to the explain output - I don't like
the code much there as it has to look into RTE but on the other hand I
don't want to create new scan node just so it can hold the name of the
sampling method for explain
- made views containing TABLESAMPLE clause not autoupdatable
- added PageIsAllVisible() check before trying to check for tuple visibility
- some typo/white space fixes
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-separate-block-sampling-functions-v2.patch | text/x-diff | 21.9 KB |
| 0002-tablesample-v12.patch | text/x-diff | 117.9 KB |
| 0003-tablesample-ddl-v7.patch | text/x-diff | 61.6 KB |
| 0004-tablesample-api-doc-v1.patch | text/x-diff | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2015-04-06 18:10:53 | Re: Exposing PG_VERSION_NUM in pg_config |
| Previous Message | Christian Almeida | 2015-04-06 17:54:52 | Re: BUG #12989: pg_size_pretty with negative values |