[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings/node): Format binding.js #9738

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kenjiding
Copy link
Contributor

Description:

The bunding.js code is not formatted correctly, resulting in a lack of smooth and natural reading

@kenjiding kenjiding requested a review from a team as a code owner November 12, 2024 12:26
Copy link
changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 6186fa0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9738 will degrade performances by 3.32%

Comparing kenjiding:fix/core_binding_code_format (6186fa0) with main (aa0f784)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kenjiding:fix/core_binding_code_format Change
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.6 µs -3.32%

@kdy1 kdy1 self-assigned this Nov 14, 2024
@kdy1 kdy1 added this to the Planned milestone Nov 14, 2024
@kdy1 kdy1 changed the title fix: format binding.js code better from core chore(bindings/node): Format binding.js Nov 14, 2024
@kdy1 kdy1 merged commit 9f8c14f into swc-project:main Nov 14, 2024
151 of 153 checks passed
@kdy1 kdy1 modified the milestones: Planned, 1.9.3 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants