[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRemixStub -> createRoutesStub #11692

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

ryanflorence
Copy link
Member

No description provided.

Copy link
changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 7ad753e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
react-router Major
react-router-dom Major
@react-router/dev Major
@react-router/server-runtime Major
@react-router/node Major
@react-router/express Major
@react-router/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 348 to 349
export type { RoutesTestStubProps as RemixStubProps } from "./lib/dom/ssr/create-remix-stub";
export { createRoutesStub as createRoutesStub } from "./lib/dom/ssr/create-remix-stub";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type { RoutesTestStubProps as RemixStubProps } from "./lib/dom/ssr/create-remix-stub";
export { createRoutesStub as createRoutesStub } from "./lib/dom/ssr/create-remix-stub";
export type { RoutesTestStubProps } from "./lib/dom/ssr/create-remix-stub";
export { createRoutesStub } from "./lib/dom/ssr/create-remix-stub";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, didn't save the file 😅

@ryanflorence ryanflorence force-pushed the ryan/create-routes-stub branch 2 times, most recently from 090ee30 to 615d36a Compare June 20, 2024 19:34
@ryanflorence ryanflorence merged commit 9e82a04 into v7 Jun 20, 2024
5 checks passed
@ryanflorence ryanflorence deleted the ryan/create-routes-stub branch June 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants