Remove redundant steps in alabel() #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I found some portions of alabel() which are either unreachable or redundant.
is not reachable because an empty string would be caught by
ulabel(label_bytes)
in the preceding try-block.is redundant as
label
is already a str, if it was not a str it would have been caught by the preceding try-block.We can simplify
label_bytes
as_alabel_prefix + _punycode(label)
.