Regen bindings with new gir {g,s}etter annotations #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
722131c
to
bb1b6ff
Compare
sdroege
reviewed
Jun 2, 2024
| @@ -290,11 +295,6 @@ pub trait DisplayExt: IsA<Display> + sealed::Sealed + 'static { | |||
| } | |||
| } | |||
|
|
|||
| #[doc(alias = "input-shapes")] | |||
| fn is_input_shapes(&self) -> bool { | |||
There was a problem hiding this comment.
This is gone now and merged with the getter function. Nice!
sdroege
reviewed
Jun 2, 2024
There was a problem hiding this comment.
Looks nice to me, some redundant properties got removed (so you probably don't want to backport this @bilelmoussaoui )
yeah, not planning to do any release till the one in mid-july anyways. Will review and merge things once I am done with dealing with the ffi renames in gstreamer |
4470b19
to
ba86fa6
Compare
|
Could you update gir & regen? |
Done. |
We lost set_paintable and others in the last commit and all these _from_ are rarely used nor idiomatic.
|
the typos ci is unrelated, will fix in a separate commit. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.