Deprecate save-always input
#1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `save-always` input added in v4 is not working as intended due to `post-if` expressions not supporting the input context. To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5). See #1315 for more details.
This was referenced Aug 14, 2024
yacaovsnc
approved these changes
Aug 14, 2024
yacaovsnc
approved these changes
Aug 14, 2024
Merged
1 task
alkino
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Oct 21, 2024
Here is the depreciation: actions/cache#1452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
save-alwaysinput added in v4 is not working as intended due topost-ifexpressions not supporting the input context.To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5).
This also fixes our documentation for how to properly use the recommended alternative of a separate
actions/cache/savestep, which requires checking thecache-hitoutput to avoid attempting to save a cache that already exists.Motivation and Context
if: always()withcache/savemay lead to errors (fix README!) #1154How Has This Been Tested?
Validated that the input had a deprecation message: https://github.com/joshmgross/actions-testing/actions/runs/10395133356
Screenshots (if appropriate):
Types of changes
Since
save-alwaysis already broken, I do not consider this a breaking change.Checklist: