[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix referenced output key in save action readme #1061

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Fix referenced output key in save action readme #1061

merged 4 commits into from
Jan 16, 2023

Conversation

ruudk
Copy link
Contributor
@ruudk ruudk commented Jan 6, 2023

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ruudk ruudk requested a review from a team as a code owner January 6, 2023 14:27
@github-actions github-actions bot requested a review from vsvipul January 6, 2023 14:27
vsvipul
vsvipul approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor
@vsvipul vsvipul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm acc to definition https://github.com/actions/cache/blob/main/restore/action.yml .
@kotewar Please take a look as well if this change is required at other places.

@kotewar kotewar merged commit 22cbf49 into actions:main Jan 16, 2023
@shango420
Copy link

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

2b97eb3192ed27ad81a555e87f3f9de61c11a213

@Teddy-van-Jerry Teddy-van-Jerry mentioned this pull request Jan 31, 2023
Merged
Dakshjain1 pushed a commit to SvavaCapital/cache that referenced this pull request Apr 19, 2024
@ruudk @kotewar @Dakshjain1
Fix referenced output key in save action readme (actions#1061)
1b25f0e 
Co-authored-by: Vipul <vsvipul@github.com>
Co-authored-by: Sankalp Kotewar <98868223+kotewar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotewar kotewar kotewar approved these changes

@vsvipul vsvipul vsvipul approved these changes

Assignees

@vsvipul vsvipul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruudk @shango420 @vsvipul @kotewar