For future reference, this what I used to find non-static dataProvider functions. It iterates through all files, extracts the function names from each line with a @dataProvider annotation, and then looks within that file for the function definition. If it doesn't have static in the definition, it gets added to the output array. The "unclear functions" are when a function definition can't be found in that file. All of these cases were of a function being defined in another class.

The (final?) set of patch sets are ready for review, and involve changes in 3 repos: Wikibase, WikibaseLexeme and WikibaseCirrusSearch

Another batch of these is ready for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1084182

pull request: https://github.com/wmde/new-lexeme-special-page/pull/790

The 4 patch sets fix the dataProvider functions in 59 files. I thought these were reasonably sized chunks to review, but am open to combining them, or breaking them up further as needed.

I noticed that wikibase-entity-summary-restore has a similar issue in which the revision number isn't a link. It also lacks the link to the revision author's talk page. This is what it is currently:

https://github.com/wmde/new-lexeme-special-page/pull/778

My current understanding is that yes, Wikit was overriding the skin styles. But, this was due to some limitations of Wikit itself, which are not a factor with Codex.

Updated 3 dependencies in WikibaseQualityConstraints: jasmine, sinon, eslint-plugin-jasmine

The top-level application of the codex link mixin is causing problems with some links, which is covered by T373989. There's currently a discussion about scoping the link styling differently. The proposed solutions so far would still result in Special New Lexeme links being styled with codex.

@ArthurTaylor suggested in a different ticket to push the changes to beta from where i could then review the changes. would that be an option?

For reference, that suggestion is in T370052. Wherever that conversation ends up, we'll do the same to review this ticket.

hey @Charlie_WMDE! Looks like I misunderstood how changes in Special New Lexeme make it to a reviewable state. It's not possible to review it in the full wiki context yet.

Here's the standalone preview, which lacks the correct styling.

github link: https://github.com/wmde/new-lexeme-special-page/pull/767