Maniphest T379193

Donate button on payments should have a clearer focus state
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pcoombe
	Nov 6 2024, 7:21 PM

Tags

Referenced Files

	F57686287: focused.png
	Nov 6 2024, 7:21 PM

	F57686285: unfocused.png
	Nov 6 2024, 7:21 PM

Subscribers

Description

To reproduce

open a payments form e.g. Adyen UK credit card
press tab repeatedly through the fields until reaching the Donate button

Result
There is a change in outline when the button is focused, but it is barely visible

unfocused	focused

Expected result
Something more visible, like the Codex buttons focus states https://doc.wikimedia.org/codex/latest/components/demos/button.html#interaction-states

Details

	Subject	Repo	Branch	Lines +/-
	Make donate button focus visable	mediawiki/extensions/DonationInterface	master	+5 -0

Customize query in gerrit

Event Timeline

Pcoombe created this task.Nov 6 2024, 7:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2024, 7:21 PM

AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Nov 12 2024, 9:15 PM

AKanji-WMF moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Tue, Nov 19, 8:38 PM

AKanji-WMF added a project: Fundraising Sprint: wwwwwwwwwwwwwww().Tue, Nov 19, 9:15 PM

Change #1093409 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Make donate button focus visable

https://gerrit.wikimedia.org/r/1093409

gerritbot added a project: Patch-For-Review.Wed, Nov 20, 6:54 PM

AnnWF claimed this task.Wed, Nov 20, 6:54 PM

AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint: wwwwwwwwwwwwwww() board.

Change #1093409 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Make donate button focus visable

https://gerrit.wikimedia.org/r/1093409

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Fri, Nov 22, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Fri, Nov 22, 5:30 AM

AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: wwwwwwwwwwwwwww() board.Fri, Nov 22, 1:02 PM

jgleeson moved this task from Pending Deployment to Done on the Fundraising Sprint: wwwwwwwwwwwwwww() board.Mon, Dec 2, 7:52 PM

XenoRyet closed this task as Resolved.Mon, Dec 2, 8:41 PM

XenoRyet set Final Story Points to 1.