Maniphest T376195

0.00 native Google Pay payment
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Cstone
	Oct 1 2024, 6:49 PM

Tags

Referenced Files

None

Subscribers

Description

This somehow got past the inapp validation which only allows 1.00 or higher

contribution tracking
219197881

&
220742450.1 at 10/29/2024

Details

	Subject	Repo	Branch	Lines +/-
	Add amount validation for inapp payment submit	mediawiki/extensions/DonationInterface	master	+19 -0

Customize query in gerrit

Related Objects

Mentioned Here: T378397: Add some unit tests for in-app api calls

Event Timeline

Cstone created this task.Oct 1 2024, 6:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2024, 6:49 PM

AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Oct 7 2024, 8:21 PM

AKanji-WMF added a project: Fundraising Tech - Chaos Crew.

greg triaged this task as High priority.Oct 8 2024, 6:25 PM

Cstone moved this task from Backlog to User Bug Backlog on the Fundraising Tech - Chaos Crew board.Oct 15 2024, 7:42 PM

AnnWF claimed this task.Oct 22 2024, 4:39 PM

AnnWF moved this task from User Bug Backlog to In Progress on the Fundraising Tech - Chaos Crew board.

currently the validateAmount is in web level only, we need to add additional check for this api call

Change #1082255 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add amount validation for inapp payment submit

https://gerrit.wikimedia.org/r/1082255

gerritbot added a project: Patch-For-Review.Oct 22 2024, 5:53 PM

AnnWF moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.Oct 22 2024, 5:54 PM

AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Tech - Chaos Crew board.Oct 28 2024, 4:52 PM

We will add some unit tests T378397

AnnWF updated the task description. (Show Details)Oct 30 2024, 1:02 AM

AnnWF moved this task from Being Reviewed to Ready for Review on the Fundraising Tech - Chaos Crew board.Nov 4 2024, 4:25 PM

Change #1082255 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add amount validation for inapp payment submit

https://gerrit.wikimedia.org/r/1082255

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 7 2024, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2024, 7:31 PM

AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.Nov 9 2024, 1:28 AM

Damilare moved this task from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.Nov 18 2024, 8:35 PM

XenoRyet closed this task as Resolved.Nov 18 2024, 8:36 PM

XenoRyet set Final Story Points to 2.