[go: up one dir, main page]

Page MenuHomePhabricator

Banners keep getting created which turn footer white in dark mode
Closed, ResolvedPublicBUG REPORT

Description

Banners keep getting enabled with CSS that changes the mobile skin in dark mode. Since this has happened many times we should find a way to stop this happening possibly via AbuseFilter?

Steps to replicate the issue (include links if applicable):

  • open en.m.wikipedia.org or pa.m.wikipedia.org or wikimedia commons (mobile) or wikidata (mobile) with a banner that has `.mw-mf-page-center {

background-color: #fff; }` in styles.

What happens?:
footer is not in dark mode

What should have happened instead?:
dark mode should be applied to footer

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Screenshot 2024-09-01 at 7.31.26 PM.png (1×2 px, 346 KB)
pa.m.wikipedia.org screeshot
IMG_20240901_203828.jpg (2×1 px, 345 KB)
Wikimedia Commons screenshot

Event Timeline

Kuldeepburjbhalaike renamed this task from footer on wikipedia is broken in night mode on mobile to footer on wikipedia and Commons is broken in night mode on mobile.Sep 1 2024, 3:11 PM
Kuldeepburjbhalaike updated the task description. (Show Details)
Aklapper changed the task status from Open to Stalled.Sep 1 2024, 5:28 PM

Cannot reproduce with Firefox 130:

Screenshot from 2024-09-01 19-27-03.png (966×961 px, 178 KB)

Does this also happen in safemode?: https://commons.m.wikimedia.org/wiki/Main_Page?safemode=true
Which exact browser(s) and version(s) did you test?

Aklapper renamed this task from footer on wikipedia and Commons is broken in night mode on mobile to footer on wikipedia and Commons still shown as light in night mode on mobile.Sep 1 2024, 5:29 PM

@Aklapper, yes also happen in safemode. chrome on mac (Version 127.0.6533.122 (Official Build) (x86_64)) and chrome on android (127.0.6533.103)

Cannot reproduce with Chrome 128.0.6613.99 on Android 10, going to https://commons.m.wikimedia.org/wiki/?minervanightmode=1 while being logged out - footer is dark. Does it still happen for you on that exact web address when you are logged out?

Still able to reproduce on android 13 and macos 13.6.9

Screenshot_2024-09-03-18-37-30-162_com.android.chrome.jpg (2×1 px, 498 KB)

IMG_20240903_184024_204.png (1×2 px, 460 KB)

Kuldeepburjbhalaike renamed this task from footer on wikipedia and Commons still shown as light in night mode on mobile to footer on wikimedia projects still shown as light in night mode on mobile.Sep 3 2024, 1:28 PM
Kuldeepburjbhalaike updated the task description. (Show Details)

Did you do a full refresh, emptying your cache? I also had the issue on my work computer but it went away after that.

@Sjoerddebruin, Emptied all cache but unfortunately still there:(

I would guess this was an issue on es.wp also, since en.wp just got a note that they "fixed" it.

Kuldeepburjbhalaike changed the task status from Stalled to Open.Sep 12 2024, 12:31 PM

Specifically "mw-mf-page-center {
background-color: #fff; }" keeps getting copied to banners for some reason. We should set up AbuseFilter rules on meta to prevent this, this is occuring way too often.

Jdlrobson renamed this task from footer on wikimedia projects still shown as light in night mode on mobile to Banners keep getting created which turn footer white in dark mode.Sep 12 2024, 2:35 PM
Jdlrobson added a subscriber: sgrabarczuk.

Hi!

So your issue is actually with community/WMF requested banners, not the fund raising ones? The former are created by volunteers (like me), the latter by the fundraising team.
Volunteers tried to raise this and requested support for our banners to make sure they work with dark mode, some work was done in T315148.

Hi!

So your issue is actually with community/WMF requested banners, not the fund raising ones? The former are created by volunteers (like me), the latter by the fundraising team.
Volunteers tried to raise this and requested support for our banners to make sure they work with dark mode, some work was done in T315148.

Hi @Ciell - my understanding is often banners get copied and pasted from a template or from other banners, and there is a trend of copying a banner with a bug in it. There are 3000+ template banners with this bug in it:
https://meta.m.wikimedia.org/w/index.php?search=insource%3A%2F%5C%23mw-mf-page-center%2F&title=Special:Search&profile=advanced&fulltext=1&ns8=1&searchToken=bxn2darj28mvaf9cv828mzbom

One way to solve this problem might be to update all the banners to remove this problematic line.
Another might be to add an AbuseFilter rule to stop new banners being created with this problematic line.

I am not too familiar with the workflow here to know what's the best solution, but this is at least the fifth time I've seen this problem in production so we should do something here.

Not every former banner will be used as a template, but then again, we sometimes do copy 'last years banner' for a yearly campaign.
I know that all WLM banners that are up now (23, I think, 30 more next month) are not yet adjusted to the new dark mode, and my guess would be that 95% of all our banners in general are not yet ready for dark mode. We simply did not have the time, knowledge, or received the support to do so.

So instead of setting up an abuse filter, let's find a way for WMF folks to work with our team of ~6 active CN volunteers to improve the banners that we put up on community or WMF request.

Hi @Ciell I think you are misunderstanding the request here. I am not asking to adjust these banners to work in dark mode. These banners have a bug in the wikitext that impacts UI outside the banner that needs to be fixed. Ie. it's not an issue that the banner has a white background, the issue is that it causes the mobile footer to become white and be unreadable - which makes the privacy policy and terms of use and license unreadable.

I have fixed all the current WLM banners - example diff, plus Community_banner_templatev3 and Community_banner_templatev4. Checked other live and scheduled banners and didn't see any with this problem.

The 3000+ banners is an overestimate, that search includes a lot of fundraising banners which are adding padding to the footer so their fixed position components don't cover the footer. More clear in this search sorting by creation date. I haven't yet found a great search to single out the actual problem ones which doesn't time out, will keep looking

Starting from a search like this one may help. A minor adjustment identifies the set of pages that could potentially be reaching into the rest of the page. Actually not a lot.

Pcoombe claimed this task.

AbuseFilter doesn't work with the Centralnotice editing interface as far as I can tell.

New problem banners search. I've fixed all the banners I could find going back to the start of 2021, except for

  • the 2022 and 2021 Wiki Loves Monuments banners where there are 2024 and 2023 ones to clone from
  • any Fundraising banners since we aren't likely to clone from them (and if we do for some reason I'll make sure this gets fixed)

So this should hopefully stop the problem getting cloned to new banners. I'll continue working on new templates