[go: up one dir, main page]

Page MenuHomePhabricator

#time is not using Month-gen messages for Croatian
Closed, ResolvedPublicBUG REPORT

Description

The time parser functions are not using the MediaWiki:Month-gen messages for month names in Croatian, so {{#timel:xg|2024-11-22}} returns MediaWiki:November/hr (studeni) instead of MediaWiki:November-gen/hr (studenoga).
This bug was exposed recently (and not for the first time) when a user reverted edits for the nominative case month names at translatewiki to what they're supposed to be. I can override them locally at hrwiki, but this needs to be fixed once and for all because ghosts of the bug being used as a feature appear every now and then on other wikis (Commons, for example).

Polish, Ukrainian, Russian and some other Slavic languages have this done right.

Expectations:

  • Genitive for 2024-11-22 → 22. studenoga 2024.
  • Nominative for 2024-11 → studeni 2024.

Event Timeline

@Umherirrender : oh, what a mess. I have no idea why they did that. The local Month-gen messages were in the nominative case. I've deleted them.

I created the local MediaWiki:August and MediaWiki:September messages with the month names in the genitive case so our signatures (~~~~) would work. You can see that they differ in these two edits here (genitive:kolovozA).

MediaWiki:Month is also what's shown in revision lists (recent changes, page history etc.), we'd want that to be MediaWiki:Month-gen

So the question here is: what exactly formats the dates in ~~~~'s and edit revision lists?

PS
Ukrainian Wikipedia page history uses the genitive form for August (N:серпень, G:серпня), but the same page with uselang=hr uses the Croatian month name in the nominative case (N:kolovoz, G:kolovoza).

The $dateFormats in languages/messages/MessagesHr.php needs to use xg instead of F, at least it is used in MessagesUk.php.

Change #1069116 had a related patch set uploaded (by Aklapper; author: Ivi104):

[mediawiki/core@master] #time should use Month-gen messages in Croatian

https://gerrit.wikimedia.org/r/1069116

The two patches should fix all the problems. How soon can we have this? It only affects hrwiki, and I hope it can be treated with some urgency (some of our automatic templates are failing).
Thanks all!

@Aklapper The patch has been live for more than two weeks now with no complaints. What are the next steps for deploying this change into production? As @Ponor has stated above, it is a matter of some urgency. Thank you!

Adding a note here, as I am discussing the patches at Discord. We're removing mdy and ymd because they are not valid date formats in Croatian. For example: Studeni 28. 2024. and 2024. studeni 28. make no sense in Croatian.

Change #1069116 merged by jenkins-bot:

[mediawiki/core@master] #time should use Month-gen messages in Croatian

https://gerrit.wikimedia.org/r/1069116

Umherirrender assigned this task to Ivi104.

The change is now merged and get deployed to wmf wikis with the next version (1.43.0-wmf.25), see the roadmap for the date and the wikis - https://www.mediawiki.org/wiki/MediaWiki_1.43/Roadmap