[go: up one dir, main page]

Page MenuHomePhabricator

Wikidata items do not work in dark mode
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Alternatively, go directly to https://www.wikidata.org/wiki/Q36500248?vectornightmode=1&useskin=vector-2022

What happens?:

image.png (871×1 px, 91 KB)

The aliases and sitelinks sections are completely unreadable, and the other properties still have a light background/dark text and not a dark background/light text.

What should have happened instead?:
The page works in night mode

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.43.0-wmf.12

Other information (browser name/version, screenshots, etc.):
FF 115.12.0esr-1

Event Timeline

This just shows the technical debt the Wikidata interface has had for more than 10 years. A rewrite to Codex is probably easier at this point.

Bugreporter subscribed.

See also T273600: Migrate Entity Page Views from JQuery to Vue and T54136: [Epic] Redesign Item UI for Wikidata repo. To use Codex to rewrite Wikibase interface may require server-side rendering of Codex, which we currently do not have.

Using the “dark mode toggle” gadget, this looks totally fine to me to be honest:

image.png (926×1 px, 201 KB)

image.png (926×1 px, 184 KB)

I haven’t been able to find any other dark mode – even in Vector 2022 (which is not our default skin)., the toggle I know from English Wikipedia isn’t shown.

Using the “dark mode toggle” gadget, this looks totally fine to me to be honest:

image.png (926×1 px, 201 KB)

image.png (926×1 px, 184 KB)

I haven’t been able to find any other dark mode – even in Vector 2022 (which is not our default skin)., the toggle I know from English Wikipedia isn’t shown.

Enabling the Accessibility for reading beta feature should give the option in Vector 2022 if it has not been rolled out to everyone yet.

Here's a replication URL:
https://www.wikidata.org/wiki/Q36500248?vectornightmode=1&useskin=vector-2022

This is for Vector 2022, not Vector. Vector development is pretty much frozen at this point and won't be getting an official dark mode outside the existing gadget.

Can someone please share some actual reproduction steps for this issue that explain how a normal user might encounter it? The replication URL is a convenient shortcut, but IMHO it alone doesn’t demonstrate that this is actually an issue people run into; and the beta feature mentioned by @Sjoerddebruin doesn’t appear to exist on Wikidata as far as I can tell.

Replication:

You have 375 users according to https://www.wikidata.org/wiki/Special:Preferences#mw-prefsection-betafeatures and people are reporting this issue:
https://m.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading/Reporting/www.wikidata.org

Dark mode is currently enabled for all wikipedias. At some point we will need to enable it for all wikis.

I guess Wikidata is currently on legacy Vector which is no longer seeing new features but the feature is available on mobile:

  • login
  • go to settings
  • click advanced mode
  • after page refresh set dark theme

WTF, the beta feature is only shown when you’re in Vector 2022?! I guess that explains this confusion…

Anyway, this is definitely something for Product to prioritize, I just wanted to have some clarity about what the issue even is.

WTF, the beta feature is only shown when you’re in Vector 2022?! I guess that explains this confusion…

Some beta features are skin specific. It wouldn't make sense to show a beta feature for a skin that it has no effect on. Note many preferences work this way:
https://codesearch.wmcloud.org/search/?q=hide-if&files=&excludeFiles=&repos=

Anyway, this is definitely something for Product to prioritize, I just wanted to have some clarity about what the issue even is.

In terms of the issue - anything using Codex design tokens will just work by default.
So for example here you can safely and quickly change the following to use a Codex design token (most extensions have been able to fix this with a single patch that does find/replace):
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/d7368ffba4422b9ad3c53e2d3d0b6f410e38a49b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css#27

e.g.

background: #eaecf0;

becomes:

background: var( --background-color-neutral, #eaecf0 /* fallback defined for skins that do not support CSS variables e.g. Vector legacy */ );

If you can't use design tokens for whatever reason, you can define your own CSS variables or provide overrides as described in https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis . Feel free to reach out to me directly and I can provide further guidance on these options if needed.