[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T360229

Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()
Open, In Progress, LowestPublic
Actions

Description

We have various lines of constructing the various GET parameters for the href value by appending strings together; instead, we should add values to an array and at the end set it once with the wfArrayToCgi() built-in MediaWiki function.

Details

SubjectRepoBranchLines +/-
PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()mediawiki/extensions/WikiLambdamaster+12 -3
PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()mediawiki/extensions/WikiLambdamaster+12 -3
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Mar 15 2024, 7:46 PM
Philipnelson99 subscribed.Mar 19 2024, 9:38 PM
DVrandecic triaged this task as Lowest priority.Mar 21 2024, 4:48 PM
DVrandecic moved this task from To triage to Backlog on the Abstract Wikipedia team board.
Philipnelson99 claimed this task.Mar 29 2024, 3:16 AM

I'll be submitting a patchset for this soon.

Jdforrester-WMF changed the task status from Open to In Progress.Apr 1 2024, 6:04 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
In T360229#9672177, @Philipnelson99 wrote:

I'll be submitting a patchset for this soon.

Brilliant. If you need any help/advice, please shout!

Philipnelson99 added a comment.EditedApr 5 2024, 3:28 AM

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Jdforrester-WMF added a comment.Apr 8 2024, 3:19 PM
In T360229#9691441, @Philipnelson99 wrote:

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Yup, sorry for the delay, that's right.

Jdforrester-WMF moved this task from In Progress to Backlog on the Abstract Wikipedia team board.Apr 29 2024, 6:04 PM
Philipnelson99 added a comment.Jun 7 2024, 10:19 PM

Sorry, I'm going to remove myself from being assigned for time being. I did make some progress but got too busy IRL and forgot all about it.

Philipnelson99 removed Philipnelson99 as the assignee of this task.Jun 7 2024, 10:19 PM
Pppery changed the task status from In Progress to Open.Aug 11 2024, 11:40 PM
gerritbot added a comment.Aug 23 2024, 6:38 PM

Change #1065263 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1065263

gerritbot added a project: Patch-For-Review.Aug 23 2024, 6:38 PM
Adityakumar0545 closed this task as Resolved.Aug 25 2024, 3:51 AM
Adityakumar0545 claimed this task.
Adityakumar0545 subscribed.

I have fixed this bug, could you please check it and give me review ?

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1065263

Pppery reopened this task as Open.Aug 25 2024, 4:05 AM
Pppery subscribed.

Not fixed until the patch is merged.

Pppery unsubscribed.Aug 25 2024, 4:47 AM
Adityakumar0545 changed the task status from Open to In Progress.Aug 25 2024, 5:36 PM

ok I am resolving it

gerritbot added a comment.Aug 26 2024, 3:18 AM

Change #1066314 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1066314

gerritbot added a comment.Aug 26 2024, 3:19 AM

Change #1066314 abandoned by Aditya0545:

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1066314

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Sep 4 2024, 3:16 AM
Jdforrester-WMF moved this task from Backlog to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Tue, Nov 12, 5:02 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Wed, Nov 13, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits