[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T354099

FancyCaptcha isn't compatible with pillow 10.x
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Reedy
Authored By
MwMajestix
Dec 29 2023, 4:46 PM
Tags
Referenced Files
F56534317: Screenshot 2024-07-19 at 15.28.25.png
Jul 19 2024, 2:29 PM
F56534297: Screenshot 2024-07-19 at 15.27.49.png
Jul 19 2024, 2:29 PM
F56534015: Screenshot 2024-07-19 at 15.20.56.png
Jul 19 2024, 2:29 PM
F42653872: image_e670453b_fde1b41bcdd829ec.png
Mar 15 2024, 9:07 PM
Subscribers
Aklapper
• Ladsgroup
MwMajestix
Reedy
TheDJ

Description

install (current) Pillow

pip install pillow (comment: Pillow 10.x was installed)

python3 captcha.py --font=/usr/share/fonts/truetype/freefont/FreeSansBold.ttf --wordlist=/usr/share/dict/words --key=wikiFOO --output=../../resources/assets/captcha --count=100
Generating 100 CAPTCHA images separated in 100 image(s) per chunk run by 1 threads...
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/var/www/vhosts/compusofia.com/httpdocs/w/extensions/ConfirmEdit/captcha.py", line 218, in run_in_thread
    gen_captcha(word, font, fontsize, os.path.join(output, filename))
  File "/var/www/vhosts/compusofia.com/httpdocs/w/extensions/ConfirmEdit/captcha.py", line 84, in gen_captcha
    dim = font.getsize(text)
AttributeError: 'FreeTypeFont' object has no attribute 'getsize'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/var/www/vhosts/compusofia.com/httpdocs/w/extensions/ConfirmEdit/captcha.py", line 301, in <module>
    p.map(run_in_thread, data)
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 367, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 774, in get
    raise self._value
AttributeError: 'FreeTypeFont' object has no attribute 'getsize'

outcome: no captchas created

install Pillow 9.5.0

pip uninstall Pillow
pip install Pillow==9.5.0

python3 captcha.py --font=/usr/share/fonts/truetype/freefont/FreeSansBold.ttf --wordlist=/usr/share/dict/words --key=wikiFOO --output=../../resources/assets/captcha --count=100
Generating 100 CAPTCHA images separated in 100 image(s) per chunk run by 1 threads...
/var/www/vhosts/compusofia.com/httpdocs/w/extensions/ConfirmEdit/captcha.py:84:** DeprecationWarning: getsize is deprecated and will be removed in Pillow 10** (2023-07-01). Use getbbox or getlength instead.
  dim = font.getsize(text)

outcome: captchas successfully created

Software version
Mediawiki 1.4.1 - ConfirmEdit from .gz file

Other information
Ubuntu 22.04.3 LTS, python3.10, Pillow 10.x.x, Pillow 9.5.0

Details

SubjectRepoBranchLines +/-
captcha.py: Swap x0/x1 and y0/y1 values before d.arc() callmediawiki/extensions/ConfirmEditREL1_41+59 -0
captcha.py: Swap x0/x1 and y0/y1 values before d.arc() callmediawiki/extensions/ConfirmEditREL1_42+18 -11
captcha.py: Swap x0/x1 and y0/y1 values before d.arc() callmediawiki/extensions/ConfirmEditmaster+18 -11
captca.py: Fix PIL 10 support againmediawiki/extensions/ConfirmEditmaster+6 -1
captcha(-old).py: Support Pillow 10mediawiki/extensions/ConfirmEditREL1_40+22 -2
captcha(-old).py: Support Pillow 10mediawiki/extensions/ConfirmEditREL1_39+22 -2
captcha(-old).py: Support Pillow 10mediawiki/extensions/ConfirmEditREL1_41+22 -2
captcha(-old).py: Support Pillow 10mediawiki/extensions/ConfirmEditmaster+22 -2
Customize query in gerrit

Related Objects

Event Timeline

MwMajestix created this task.Dec 29 2023, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2023, 4:46 PM
Pppery renamed this task from xtension:ConfirmEdit/FancyCaptcha: creating captcha files is either not working or throws error to FancyCaptcha: creating captcha files is either not working or throws error.Dec 29 2023, 6:35 PM
Pppery added a project: ConfirmEdit (CAPTCHA extension).
Reedy renamed this task from FancyCaptcha: creating captcha files is either not working or throws error to FancyCaptcha isn't compatible with pillow 10.x.Jan 2 2024, 2:35 AM
Reedy subscribed.Jan 2 2024, 2:41 AM

https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html#font-size-and-offset-methods

gerritbot added a comment.Jan 2 2024, 2:46 AM

Change 986864 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@master] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/986864

gerritbot added a project: Patch-For-Review.Jan 2 2024, 2:46 AM
Reedy added projects: MW-1.39-release, MW-1.40-release, MW-1.41-release.Jan 2 2024, 2:47 AM
Reedy moved this task from Backlog to Awaiting Code Review on the ConfirmEdit (CAPTCHA extension) board.Jan 2 2024, 2:57 AM
Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.41-release board.Jan 3 2024, 5:50 PM
gerritbot added a comment.Jan 5 2024, 4:47 AM

Change 986864 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/986864

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 5 2024, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 5 2024, 5:30 AM
gerritbot added a comment.Jan 5 2024, 3:36 PM

Change 987986 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_41] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987986

gerritbot added a project: Patch-For-Review.Jan 5 2024, 3:36 PM

Change 987987 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_40] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987987

gerritbot added a comment.Jan 5 2024, 3:36 PM

Change 987988 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_39] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987988

Reedy closed this task as Resolved.Jan 5 2024, 3:36 PM
Reedy claimed this task.
gerritbot added a comment.Jan 5 2024, 3:41 PM

Change 987986 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_41] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987986

gerritbot added a comment.Jan 5 2024, 3:41 PM

Change 987988 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_39] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987988

gerritbot added a comment.Jan 5 2024, 3:41 PM

Change 987987 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_40] captcha(-old).py: Support Pillow 10

https://gerrit.wikimedia.org/r/987987

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2024, 4:30 PM
TheDJ mentioned this in T141490: Deploy improved FancyCaptcha.Jan 26 2024, 10:17 PM
gerritbot added a comment.Jan 27 2024, 2:26 PM

Change 993220 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@master] captca.py: Fix PIL 10 support again

https://gerrit.wikimedia.org/r/993220

gerritbot added a project: Patch-For-Review.Jan 27 2024, 2:26 PM
gerritbot added a comment.Jan 29 2024, 7:36 PM

Change 993220 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] captca.py: Fix PIL 10 support again

https://gerrit.wikimedia.org/r/993220

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 29 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 29 2024, 8:30 PM
TheDJ reopened this task as Open.Feb 12 2024, 8:55 PM
TheDJ subscribed.

Re-opening, to remember that it is still broken after the changes in T141490

Reedy added a comment.Feb 12 2024, 9:27 PM
In T354099#9495895, @gerritbot wrote:

Change 993220 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] captca.py: Fix PIL 10 support again

https://gerrit.wikimedia.org/r/993220

Wasn’t it fixed by ^

TheDJ added a comment.Feb 13 2024, 7:33 AM

No, check the review comments:

“in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/multiprocessing/pool.py", line 774, in get
raise self._value
ValueError: y1 must be greater than or equal to y0

“I'd say this is good to fix one part of the problem but we need another patch for the second fix. Does that sound good to you?”

• Ladsgroup subscribed.Feb 15 2024, 1:05 PM

We need add a comparison between draw points and swap them if needed. That's straightforward if anyone is willing to take a look

gerritbot added a comment.Feb 19 2024, 6:36 PM

Change 1004755 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@master] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1004755

gerritbot added a project: Patch-For-Review.Feb 19 2024, 6:36 PM
TheDJ added a comment.Mar 15 2024, 9:07 PM

@Ladsgroup I don't think this is what the intent was right ?

image_e670453b_fde1b41bcdd829ec.png (73×255 px, 3 KB)

• Ladsgroup added a comment.Mar 16 2024, 2:37 PM

is it all cases? If not, then meh if it is, then we should do something

Reedy edited projects, added MW-1.42-release; removed MW-1.40-release.Jun 27 2024, 3:43 PM
Reedy added a comment.Jul 19 2024, 2:29 PM

So trying to use the script again myself locally...

Generating 100 CAPTCHA images separated in 100 image(s) per chunk run by 1 threads...
multiprocessing.pool.RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/home/reedy/captchas/captcha.py", line 279, in run_in_thread
    gen_captcha(word, font, fontsize, os.path.join(opts.output, filename))
  File "/home/reedy/captchas/captcha.py", line 126, in gen_captcha
    d.arc(
  File "/home/reedy/.local/lib/python3.10/site-packages/PIL/ImageDraw.py", line 143, in arc
    self.draw.draw_arc(xy, start, end, ink, width)
ValueError: y1 must be greater than or equal to y0
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/reedy/captchas/captcha.py", line 426, in <module>
    p.map(run_in_thread, data)
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 367, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 774, in get
    raise self._value
ValueError: y1 must be greater than or equal to y0

If I grab the version from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/1004755, it then runs fine without issue

Screenshot 2024-07-19 at 15.20.56.png (676×1 px, 132 KB)

Any blurring etc shown is just macos being weird, they're not blurry when viewed individually...

This is with Pillow 9.5.0... So the bug for ValueError: y1 must be greater than or equal to y0 is maybe more python version related?

Python 3.10.12

If I explicitly install Pillow=10.4.0, and regenerate images...

Screenshot 2024-07-19 at 15.27.49.png (844×1 px, 171 KB)

And then vaguely compared against a random one served by WMF production

Screenshot 2024-07-19 at 15.28.25.png (308×376 px, 29 KB)

They don't seem to be dissimilar

In T354099#9635009, @TheDJ wrote:

@Ladsgroup I don't think this is what the intent was right ?

image_e670453b_fde1b41bcdd829ec.png (73×255 px, 3 KB)

I'm guessing is just a result of random-ness...

Reedy mentioned this in T369816: Create a basic test harness for anti-captcha tool and run it.Jul 19 2024, 5:23 PM
gerritbot added a comment.Jul 20 2024, 11:08 PM

Change #1004755 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1004755

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2024, 11:31 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 21 2024, 12:00 AM
gerritbot added a comment.Jul 21 2024, 10:13 AM

Change #1055575 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_42] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1055575

gerritbot added a project: Patch-For-Review.Jul 21 2024, 10:13 AM
gerritbot added a comment.Jul 21 2024, 10:21 AM

Change #1055575 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_42] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1055575

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2024, 10:30 AM
Reedy closed this task as Resolved.Jul 31 2024, 5:10 PM
gerritbot added a comment.Aug 30 2024, 5:16 PM

Change #1069252 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_41] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1069252

gerritbot added a project: Patch-For-Review.Aug 30 2024, 5:16 PM

Change #1069252 abandoned by Reedy:

[mediawiki/extensions/ConfirmEdit@REL1_41] captcha.py: Swap x0/x1 and y0/y1 values before d.arc() call

https://gerrit.wikimedia.org/r/1069252

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2024, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits