[subtask] Vector 2022 "Tools" menu collapsing does not make main content take that space anymore
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	IKhitron
	Nov 29 2023, 10:37 AM

Description

Hi. By checking Special:Version looks like the group 1 deployment is already done, still it is not Wednesday evening yet. There is a huge hole on every page. Looks like Unbreak Now! to me.
I always use the new Vector with all three collapsed sidebars. It was fine hours ago. Now the Tools menu collapsing mechanism seems to be broken.

Screenshot_20231129_121917_Samsung Internet.jpg (961×1 px, 407 KB)

Open some group 1 page, for example this one, the link includes safemode.
Make sure the Tools menu is collapsed.
Check the right side of the page.
Expected: the text continues until the right margine of the page.
Got: there is a white hole in size of the Tools menu.

Thank you.

QA Results - Prod

AC	Status	Details
1	✅	T352257#9381708

Details

	Subject	Repo	Branch	Lines +/-
	Fix incorrect client-pref-pinned classes when client pref feature is disabled	mediawiki/skins/Vector	wmf/1.42.0-wmf.7	+1 -0
	Fix incorrect client-pref-pinned classes when client pref feature is disabled	mediawiki/skins/Vector	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T313828 [EPIC] Typography: improve typography and allow for variable typography settings
Duplicate		Florian	T50946 Add font size adjustment feature
Duplicate		Jdlrobson	T91201 [GOAL] Accessibility settings/preferences on desktop and mobile
Duplicate		Jdlrobson	T345359 [Goal] Allow logged-out and logged-in users to set preferred typography
Resolved		ovasileva	T351141 Make the client preferences controls pinnable
Resolved	BUG REPORT	Jdlrobson	T352257 [subtask] Vector 2022 "Tools" menu collapsing does not make main content take that space anymore

Event Timeline

IKhitron created this task.Nov 29 2023, 10:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2023, 10:37 AM

IKhitron mentioned this in T350083: 1.42.0-wmf.7 deployment blockers.Nov 29 2023, 10:38 AM

Everything is still readable, so I'd personally would not consider this Unbreak Now for now

I think this is https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/978116
(T351141#9362427)

Change 978116 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix incorrect client-pref-pinned classes when client pref feature is disabled

https://gerrit.wikimedia.org/r/978116

Change 978513 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] Fix incorrect client-pref-pinned classes when client pref feature is disabled

https://gerrit.wikimedia.org/r/978513

Jdlrobson renamed this task from Vector 2022 "Tools" menu collapsing does not make main content take that space anymore to [subtask] Vector 2022 "Tools" menu collapsing does not make main content take that space anymore.Nov 29 2023, 8:20 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.

Jdlrobson added a parent task: T351141: Make the client preferences controls pinnable.

Change 978116 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix incorrect client-pref-pinned classes when client pref feature is disabled

https://gerrit.wikimedia.org/r/978116

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 29 2023, 9:00 PM

Change 978513 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.7] Fix incorrect client-pref-pinned classes when client pref feature is disabled

https://gerrit.wikimedia.org/r/978513

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-29T21:50:44Z] <tgr@deploy2002> Started scap: Backport for [[gerrit:978683|Update coverage of Reader Demographics 2 surveys (T344393)]], [[gerrit:978513|Fix incorrect client-pref-pinned classes when client pref feature is disabled (T351141 T352257)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-29T21:52:07Z] <tgr@deploy2002> dani and tgr and jdlrobson: Backport for [[gerrit:978683|Update coverage of Reader Demographics 2 surveys (T344393)]], [[gerrit:978513|Fix incorrect client-pref-pinned classes when client pref feature is disabled (T351141 T352257)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 29 2023, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-29T22:01:20Z] <tgr@deploy2002> Finished scap: Backport for [[gerrit:978683|Update coverage of Reader Demographics 2 surveys (T344393)]], [[gerrit:978513|Fix incorrect client-pref-pinned classes when client pref feature is disabled (T351141 T352257)]] (duration: 10m 35s)

Confirming beeing fixed, thanks a lot.

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 29 2023, 10:48 PM

ovasileva subscribed.Nov 30 2023, 7:39 AM

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.Nov 30 2023, 5:39 PM

Jdlrobson closed this task as Resolved.Dec 1 2023, 6:33 PM

Jdlrobson claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: hewiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Open some group 1 page, for example this one, the link includes safemode.
Make sure the Tools menu is collapsed.
Check the right side of the page.
✅ AC1: The text continues until the right margine of the page.

screenshot 162.mov.gif (750×1 px, 533 KB)

Edtadros attached a referenced file: F41561842: screenshot 162.mov.gif. (Show Details)Dec 5 2023, 6:18 AM

Edtadros updated the task description. (Show Details)

Edtadros mentioned this in T351126: Verify 1.42.0-wmf.7 deployment.Dec 5 2023, 8:49 AM

	F41545662: Screenshot_20231129_121917_Samsung Internet.jpg
	Nov 29 2023, 10:37 AM

[subtask] Vector 2022 "Tools" menu collapsing does not make main content take that space anymoreClosed, ResolvedPublicBUG REPORTActions