Font size should support multiple font size
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 20 2023, 5:30 PM

Description

Following up T345363, currently our font size control only supports small (the current default) and standard:
https://www.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading?vectorclientpreferences=1

Screenshot 2023-09-20 at 10.29.54 AM.png (395×443 px, 32 KB)

TODO

Repurpose the existing feature flag to support multiple sizes e.g. small, regular, large, x-large.
Update the client preferences dialog to show 4 options.

QA

https://www.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading?vectorclientpreferences=1 should show 4 options
All 4 options should work and persist across page views Note: for logged in there may be a delay in saving these preferences.

Sign off

Jon should create a ticket for paying off the technical debt we've accumulated for working around the fact client preferences doesn't work for logged in

QA Results - Beta

AC	Status	Details
1	✅	T346954#9263871
2	✅	T346954#9263871

QA Results - Prod

AC	Status	Details
1	✅	T346954#9297115
2	✅	T346954#9297115

Details

	Subject	Repo	Branch	Lines +/-
	Add multiple font size to logged-in users	mediawiki/skins/Vector	master	+26 -1
	Add multiple font size to frontend	mediawiki/skins/Vector	master	+25 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	Florian	T50946 Add font size adjustment feature
Duplicate	Jdlrobson	T91201 [GOAL] Accessibility settings/preferences on desktop and mobile
Resolved	ovasileva	T346954 Font size should support multiple font size

Event Timeline

Jdlrobson created this task.Sep 20 2023, 5:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2023, 5:30 PM

Jdlrobson triaged this task as High priority.Sep 20 2023, 5:31 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a parent task: T91201: [GOAL] Accessibility settings/preferences on desktop and mobile.

ovasileva set the point value for this task to 5.Sep 21 2023, 5:29 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Sep 25 2023, 5:38 PM

Jdlrobson moved this task from Incoming to Technical architecture on the Desktop Improvements (Vector 2022) board.Oct 2 2023, 6:29 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 9 2023, 10:05 AM

@Mabualruz want to pair on this? I want to be involved in the initial design but it might be worth you working on the bulk of this!

@Jdlrobson lets have a meeting to go over the current state and the aim, and sure I love to be involved in this it is very interesting and it have a lot of work that I like to do.

Change 965790 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Add multiple font size to frontend

https://gerrit.wikimedia.org/r/965790

gerritbot added a project: Patch-For-Review.Oct 13 2023, 6:23 PM

Hey @Mabualruz https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/965790 takes care of the frontend side of things.
I think for the backend we need to provide some kind of abstraction for a Feature

I jotted down some code at a high level to describe how this could work but I'm not attached to it.
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/965810
Given a feature can have multiple requirements I think the suffix actually belongs to the feature.

Please take a stab at this yourself, and feel free to use any of the code in that proof of concept.

• Mabualruz mentioned this in T347772: Make Vector feature flags compatible with beta features.Oct 16 2023, 5:11 PM

Mo and I synced this morning.
NExt steps:

We can merge https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/965790/ as is - no concerns from Olga about shipping something that only works for anonymous users.
Mo is going to explore a quick short term fix to search preferences table for the appropriate class suffix for logged in users
Mo is going to think about the architecture more deeply. We're open to incurring technical debt and creating a spike come Wednesday if we feel this requires more thought.

Change 965583 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Add multiple font size to logged-in users

https://gerrit.wikimedia.org/r/965583

The Patch https://gerrit.wikimedia.org/r/965583 addresses logged in user preference loading.

I will put this one in review will try to move https://phabricator.wikimedia.org/T347772 Make Vector feature flags compatible with beta features in review then will start on the architecture part here

• Mabualruz reassigned this task from • Mabualruz to Jdlrobson.Oct 17 2023, 1:10 PM

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.

Change 965790 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add multiple font size to frontend

https://gerrit.wikimedia.org/r/965790

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 2:00 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Oct 17 2023, 9:40 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.

Jdlrobson updated the task description. (Show Details)

Change 965583 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add multiple font size to logged-in users

https://gerrit.wikimedia.org/r/965583

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2023, 10:11 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: https://www.mediawiki.org/wiki/Reading/Web/Accessibility_for_reading?vectorclientpreferences=1 should show 4 options
✅ AC2: All 4 options should work and persist across page views Note: for logged in there may be a delay in saving these preferences.