[go: up one dir, main page]

Page MenuHomePhabricator

VisualEditor strings: Mark category sort keys between alternate quotation marks
Closed, DeclinedPublic

Description

[[MediaWiki:Visualeditor-changedesc-mwcategory-sortkey-changed/en]]

Sort keys are most often not defined as linguistic terms, but as abbreviation with possibly modified orthographies. In addition then may often be limted to a space or may start by a space. These keys should be visualized between alternate quotation marks (without inner spaces).

Please change:

  • "Sort key changed from $1 to $2" to "Sort key changed from ‹$1› to ‹$2›"
  • "Sort key set to $1" to "Sort key set to ‹$1›"
  • "Sort key unset from $1" to "Sort key unset from ‹$1›"

Otherwise, the sort keys are not easily to see clearly in messages to exhibit the differences.

Note that these alternate ‹technical quotation marks›, suitable for English, Spanish, Italian, French or most languages written with the Latin script, may still be translated or reversed, e.g. in ›German‹ or 「Chinese」(it's up to translators to choose what looks the best for their conventions and opening/closing directions). So they should avoid using the too common 'single' or "double" ASCII quotation marks in English.


Message URL:

Event Timeline

Verdy_p updated the task description. (Show Details)
Verdy_p updated the task description. (Show Details)
Verdy_p updated the task description. (Show Details)
Verdy_p updated the task description. (Show Details)

The sort keys are already marked up with semantic tags and highlighted visually. You can see an example here: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T337939&diff=prev&oldid=587361&diffmode=visual

image.png (927×1 px, 133 KB)

I'd recommend against adding quotation marks to avoid double emphasis. We should probably just document this in qqq.

Esanders subscribed.

Agree with @matmarex. This same pattern is also used for other attribute changes like link targets. Feel free to submit a patch to the documentation to make this clearer.

Aklapper renamed this task from [[MediaWiki:Visualeditor-changedesc-mwcategory-sortkey-changed/en]] translation issue to VisualEditor strings: Mark category sort keys between alternate quotation marks.Jun 1 2023, 3:05 PM
Aklapper removed a project: I18n.
Aklapper updated the task description. (Show Details)

Does this markup work with spaces in sort keys? (i.e. uncompressed and protected from being moved out of the span markup by the Mediawiki parser or "HTML Tidy" pass).

In HTML and CSS there's a property to avoid this compression of whitespaces when rendering text.

This question also applies to all other markup inserted for diffs. Frequently we don't see differences of whitespaces.

Verdy_p triaged this task as Low priority.

How we handle whitespace changes in attribute diffs sounds like a separate issue, so please file a separate task. I don't think adding quotations marks would help there?

Does this markup work with spaces in sort keys? (i.e. uncompressed and protected from being moved out of the span markup by the Mediawiki parser or "HTML Tidy" pass).

Yes.