InvalidArgumentException: Data for ftr_namespace and ftr_title must be non-empty
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	May 18 2023, 9:44 PM

Description

Error

service.version: 1.41.0-wmf.9
trace.id: 1f925510-0443-464b-a8ee-8ccabf77d784
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   InvalidArgumentException: Data for ftr_namespace and ftr_title must be non-empty

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/rdbms/platform/SQLPlatform.php(298)
#0 /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/rdbms/database/Database.php(3474): Wikimedia\Rdbms\Platform\SQLPlatform->makeWhereFrom2d(array, string, string)
#1 /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->makeWhereFrom2d(array, string, string)
#2 /srv/mediawiki/php-1.41.0-wmf.9/includes/libs/rdbms/database/DBConnRef.php(415): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#3 /srv/mediawiki/php-1.41.0-wmf.9/includes/cache/LinkBatch.php(377): Wikimedia\Rdbms\DBConnRef->makeWhereFrom2d(array, string, string)
#4 /srv/mediawiki/php-1.41.0-wmf.9/extensions/FlaggedRevs/backend/FRDependencyUpdate.php(173): LinkBatch->constructSet(string, Wikimedia\Rdbms\DBConnRef)
#5 /srv/mediawiki/php-1.41.0-wmf.9/extensions/FlaggedRevs/backend/FRDependencyUpdate.php(156): FRDependencyUpdate->makeWhereFrom2d(array, Wikimedia\Rdbms\DBConnRef)
#6 /srv/mediawiki/php-1.41.0-wmf.9/extensions/FlaggedRevs/backend/FRDependencyUpdate.php(83): FRDependencyUpdate->getDepDeletions(array, array)
#7 /srv/mediawiki/php-1.41.0-wmf.9/extensions/FlaggedRevs/backend/FRExtraCacheUpdateJob.php(68): FRDependencyUpdate->doUpdate(integer)
#8 /srv/mediawiki/php-1.41.0-wmf.9/extensions/FlaggedRevs/backend/FRExtraCacheUpdateJob.php(29): FRExtraCacheUpdateJob->doUpdateLinks()
#9 /srv/mediawiki/php-1.41.0-wmf.9/extensions/EventBus/includes/JobExecutor.php(79): FRExtraCacheUpdateJob->run()
#10 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#11 {main}

Impact

Unknown.

Notes

These are happening every few minutes with T330215: 1.41.0-wmf.9 deployment blockers at group2. Similar error message to T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty.

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Subject	Repo	Branch	Lines +/-
	LinkBatch: Re-apply makeWhereFrom2d/constructSet exception	mediawiki/core	master	+11 -12
	Avoid empty LinkBatch from FRDependencyUpdate::getDepDeletions	mediawiki/extensions/FlaggedRevs	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty
Mentioned Here: T330216: 1.41.0-wmf.10 deployment blockers
rMWd48115b2bfc8: cache: Do not throw on empty set in LinkBatch::constructSet
T330215: 1.41.0-wmf.9 deployment blockers
T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty

Event Timeline

brennen created this task.May 18 2023, 9:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2023, 9:44 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.May 18 2023, 9:44 PM

I would expect that both errors are the same root cause and the same fix.
But this new stack trace shows the new code line the function has after d48115b2bfc80dcd19dd12ceb26d055c984aa5e1, so still an issue.

Change 921108 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Avoid empty LinkBatch from FRDependencyUpdate::getDepDeletions

https://gerrit.wikimedia.org/r/921108

gerritbot added a project: Patch-For-Review.May 18 2023, 10:04 PM

Change 921108 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Avoid empty LinkBatch from FRDependencyUpdate::getDepDeletions

https://gerrit.wikimedia.org/r/921108

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 19 2023, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 19 2023, 8:10 AM

Krinkle added a project: Unstewarded-production-error.May 19 2023, 1:16 PM

Krinkle removed a project: MediaWiki-General.

Krinkle mentioned this in T336964: InvalidArgumentException: Data for lt_namespace and lt_title must be non-empty.May 19 2023, 1:24 PM

Is this worth backporting? Meanwhile I have added a filter to remove it from the MediaWiki New Errors dashboard.

Change 921450 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] LinkBatch: Re-apply makeWhereFrom2d/constructSet exception

https://gerrit.wikimedia.org/r/921450

gerritbot added a project: Patch-For-Review.May 20 2023, 9:10 AM

Ping! Just want to make sure this doesn't get overlooked. These errors are flowing at a steady rate.

In T336980#8878159, @dancy wrote:

Ping! Just want to make sure this doesn't get overlooked. These errors are flowing at a steady rate.

The error should have stopped with the deployment of wmf.10 (T330216).
There is some more code clean up ongoing, but no exception should be there.

In T336980#8884106, @Umherirrender wrote:

In T336980#8878159, @dancy wrote:

Ping! Just want to make sure this doesn't get overlooked. These errors are flowing at a steady rate.

The error should have stopped with the deployment of wmf.10 (T330216).
There is some more code clean up ongoing, but no exception should be there.

Confirmed. Thank you!

Change 921450 merged by jenkins-bot:

[mediawiki/core@master] LinkBatch: Re-apply makeWhereFrom2d/constructSet exception

https://gerrit.wikimedia.org/r/921450

Umherirrender closed this task as Resolved.Jun 16 2023, 5:11 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jun 16 2023, 6:00 PM

Krinkle assigned this task to Umherirrender.Jul 27 2023, 3:38 PM

Krinkle moved this task from Untriaged to May 2023 on the Wikimedia-production-error board.

InvalidArgumentException: Data for ftr_namespace and ftr_title must be non-emptyClosed, ResolvedPublicPRODUCTION ERRORActions