[go: up one dir, main page]

Page MenuHomePhabricator

Personalized praise: Add support for Flow talk pages
Closed, ResolvedPublic

Description

As part of T322443: Personalized praise: new mentor dashboard module, a new module is being added to the Mentor dashboard, which suggests potentially praiseworthy mentees to their mentor for review and praising. The module provides the mentor with several information regarding their mentee, including the number of talk page messages the mentee has.

Currently, the code calculating the number of TP messages does not expect anything else but wikitext-based talk pages. This breaks the feature at eg. arwiki, where users may make use of Flow-based talk pages. Currently, the counter is always zero, irrespective of the actual number of talk page messages. Within this task, support for Flow-based talk page messages should be added into Personalized praise module.

Event Timeline

Change 908837 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] PersonalizedPraise: Add support for number of Flow topics

https://gerrit.wikimedia.org/r/908837

Not related this task specifically, but making four identical API requests on every step of the user carousel should really be fixed. Probably the talk page data can just be put in the store?

Also, where does the mw-heading2 used in the non-Flow version come from? I missed that in rEGRE5f6c449f9753: Frontend for Personalized praise module but I don't think we actually use that class.

Change 908837 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] PersonalizedPraise: Add support for number of Flow topics

https://gerrit.wikimedia.org/r/908837

Not related this task specifically, but making four identical API requests on every step of the user carousel should really be fixed. Probably the talk page data can just be put in the store?

Agreed. I'll move it to the store, definitely.

Also, where does the mw-heading2 used in the non-Flow version come from? I missed that in rEGRE5f6c449f9753: Frontend for Personalized praise module but I don't think we actually use that class.

From action=parse. If you check action=parse output for my talk, you'll see many divs with classes like mw-heading mw-heading2. It might be a DiscussionTools-provided enhancement (which wouldn't be an issue, as we interact with DiscussionTools closely anyway).

Hm, it didn't work for me locally, I'll test again with DiscussionTools installed.

Etonkovidova subscribed.

The case when a user has Flow user talk page - "Send praise" will redirect a mentor to the page (no pre-filled message).
The case when a user talk page is not Flow-based - a pre-filled message will be displayed:

Screen Shot 2023-05-16 at 4.36.30 PM.png (1×2 px, 210 KB)