[go: up one dir, main page]

Page MenuHomePhabricator

[L] [betalabs] - Vue warnings on Special:Search when search preview is clicked
Closed, ResolvedPublic

Description

Note: Search preview is not displayed when &debug=true.

  1. Perform any search on Special:Search in betalabs (with &debug=true and Vue devtools browser extension installed), e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?search=cat&title=Special:Search&profile=advanced&fulltext=1&ns0=1&debug=true&quickView=Andean+mountain+cat
  2. Click to see search preview for any article - the arrow will be displayed, but clicking on it will not display the search preview:

Screen Shot 2023-02-21 at 6.47.32 PM.png (710×2 px, 336 KB)

The Console displays several Vue warnings:

[Vue warn]: (deprecation GLOBAL_PROTOTYPE) Vue.prototype is no longer available in Vue 3. Use app.config.globalProperties instead.
[Vue warn]: Directive "i18n-html" has already been registered in target app.
[Vue warn]: (deprecation CONFIG_WHITESPACE) Vue 3 compiler's whitespace option will default to "condense" instead of "preserve". To suppress this warning, provide an explicit value for `config.compilerOptions.whitespace`
[Vue warn]: Extraneous non-props attributes (role, tabindex, title, aria-label) were passed to component but could not be automatically inherited because component renders fragment or text root nodes. 
  at <QuickView key=0 class="mw-app-view-desktop mw-search-quick-view"   ... > 
  at <SearchVue role="dialog" tabindex="-1" title="Search Preview"  ... > 
  at <SearchVue>
[Vue warn]: Missing required prop: "source" 
  at <QuickViewImage key=0 width=90 height=74  ... > 
  at <QuickView key=0 class="mw-app-view-desktop mw-search-quick-view"   ... > 
  at <SearchVue role="dialog" tabindex="-1" title="Search Preview"  ... > 
  at <SearchVue>
[Vue warn]: Invalid prop: type check failed for prop "src". Expected String with value "undefined", got Undefined  
  at <ImageWithLoadingBackground key=undefined src=undefined alt=null  ... > 
  at <QuickViewImage key=0 width=90 height=74  ... > 
  at <QuickView key=0 class="mw-app-view-desktop mw-search-quick-view"   ... > 
  at <SearchVue role="dialog" tabindex="-1" title="Search Preview"  ... >
[Vue warn]: (deprecation WATCH_ARRAY) "watch" option or vm.$watch on an array value will no longer trigger on array mutation unless the "deep" option is specified. If current usage is intended, you can disable the compat behavior and suppress this warning with:

  configureCompat({ WATCH_ARRAY: false })

Event Timeline

@SimoneThisDot - since there is no user impact, should this task be closed or there something needs to be done later? Thx!

Etonkovidova renamed this task from [QA task] betalabs - Vue warnings on Special:Search when search preview is clicked to [betalabs] - Vue warnings on Special:Search when search preview is clicked.Feb 27 2023, 11:07 PM

According to @SimoneThisDot, this also happens on production, you just do not see it because they are warnings and in production only errors are shown.

CBogen renamed this task from [betalabs] - Vue warnings on Special:Search when search preview is clicked to [L] [betalabs] - Vue warnings on Special:Search when search preview is clicked.Mar 22 2023, 4:31 PM

Change 909553 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Vue warnings on Special:Search when search preview is clicked

https://gerrit.wikimedia.org/r/909553

All warning issues in the above Patch expect the following 2 that are coming from Core:

[Vue warn]: (deprecation GLOBAL_PROTOTYPE) Vue.prototype is no longer available in Vue 3. Use app.config.globalProperties instead.
[Vue warn]: Directive "i18n-html" has already been registered in target app.

Change 909553 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Vue warnings on Special:Search when search preview is clicked

https://gerrit.wikimedia.org/r/909553