- Open https://en.wikipedia.org/wiki/Barack_Obama?veaction=edit
- Click on a reference that uses a {{cite..}} template (most of them)
- Observe that the browser takes a few seconds to render the context item:
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned Here
- T330800: Re-duplicating TemplateStyles slows down rendering
Event Timeline
Comment Actions
The time here is spent with recalculating styles, and experimenting this appears to be the TemplateStyles <style> tag. Stripping these style tags from the preview solves the performance issue.
I think the extra <style> tag is often unnecessary because the styles are already included in the main document.
There may be other places that are being slow because of this?
Comment Actions
Change 893038 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] PreviewElement: Add a #beforeAppend method so nodes can be modified
Comment Actions
Change 893039 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] MWPreviewElement: Strip already-present TemplateStyles when building elements
Comment Actions
Change 893038 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] PreviewElement: Add a #beforeAppend method so nodes can be modified
Comment Actions
Change 897959 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bcb501475)
Comment Actions
Change 897959 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bcb501475)
Comment Actions
Change 893039 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWPreviewElement: Strip already-present TemplateStyles when building elements
Comment Actions
It takes about a second or 2 now. That's an improvement but is the target here milliseconds?