[go: up one dir, main page]

Page MenuHomePhabricator

Changes to Web2Cit monitor result pages do not trigger email notifications
Open, Needs TriagePublic

Description

Web2Cit collaborators interested in following translation test changes for a given domain are instructed to add the corresponding Web2Cit monitor result page to their watchlist, because these pages are designed in such a way that they only change if translation test results change.

However, although such changes do appear in https://meta.wikimedia.org/wiki/Special:Watchlist, they do not seem to trigger email notifications.

This may be because Web2cit-monitor-bot editions are marked as minor edits, and bot editions marked as minor edits would not trigger email notifications, even if the user has indicated in their preferences that they what to get email notifications for minor edits (see T40874).

If this is the case, I understand that adding the minorEdit=False parameter to the page.put() command in Web2Cit-Monitor's writer/domain.py (https://gitlab.wikimedia.org/superzerocool/w2c-monitor/-/blob/master/writer/domain.py#L70) would fix the issue.

In addition, doing so in the page.put() command of the write_domain_check function (https://gitlab.wikimedia.org/superzerocool/w2c-monitor/-/blob/master/writer/domain.py#L82) would enable email notifications when new domains are added to the domain list and users have this list added to their watchlist.