[go: up one dir, main page]

Page MenuHomePhabricator

Wishathon QA: Enable Thanks Button by default in Watchlists and Recent Changes
Closed, ResolvedPublic

Description

Context

During the Wishathon, work was completed to fulfill this wish. There are some edge cases that may need mending. This ticket is for QA to give a pass at the functionality achieved with this wish before it goes live on the first train of 2023.

QA the work completed for this wish:

https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2022/Notifications/Enable_Thanks_Button_by_default_in_Watchlists_and_Recent_Changes

Event Timeline

@NRodriguez I created a document below of all the options that I could find where you can use the thank option. I'll need some of your assistance to see which ones are not needed since I'm not too familiar with some of the choices. Like some of the protections and some tags. It doesn't seem like an ideal spot for thanks but I want to confirm with you. Also, I noticed on the skin MinervaNeue that it's the only skin that has a block for the thank option as seen in the screenshot below. The rest of the skins look like the ones in my document.

Skins Tested: Vector 2022, Vector 2010, Timeless, Monobook, MinervaNeue
Mac OS: 13.1
Browser: Chrome

MinervaNeue- Contributions

T325559_Wishathon_Thanks_MinervaNeue_Contribution.png (965×950 px, 133 KB)

MinervaNeue- Watchlist

T325559_Wishathon_Thanks_MinervaNeue_Watchlist.png (817×922 px, 126 KB)

@GMikesell-WMF thanks for making this list, it's very helpful to see all the user actions that can warrant a "thank you" broken down like this.

Do you have bandwidth to send me a inverse of this-- a document fleshing out what the user getting thanked sees in their notificaitons?

For now, I am not thinking it should not block the release-- some of these user actions seems really granular but I don't see any harm in thanking users for doing tedious work. What are your thoughts @ThereisNotime and @MusikAnimal
and @Samwilson

@GMikesell-WMF thanks for making this list, it's very helpful to see all the user actions that can warrant a "thank you" broken down like this.

Do you have bandwidth to send me a inverse of this-- a document fleshing out what the user getting thanked sees in their notifications?

@NRodriguez I also agree that it doesn't hurt for thanking users even though some are a little extra. Please let me know if you need anything else. Thanks!

it's very helpful to see all the user actions that can warrant a "thank you" broken down like this.

For now, I am not thinking it should not block the release-- some of these user actions seems really granular but I don't see any harm in thanking users for doing tedious work. What are your thoughts ThereisNotime and @MusikAnimal

This is controlled via configuration. It doesn't appear we override it in our production config, so it must be using the defaults which for logged actions include:

contentmodel
delete
import
merge
move
patrol
protect
tag
managetags
rights

This in addition to the ability to thank edits, which are not considered a "logged action".

As far as I know this hasn't changed since Thanks was first deployed, rather now we are able to send Thanks in more places than before (recent changes/watchlist instead of having to go to Special:Log). But the types of things you can 'thank' has not changed.