I've removed the copy TBC note, as I'm comfortable with the proposed copy:

No suggestions based on your filters
Change your topic and task filters on suggested edits for more articles to edit.

The only note I have is that the "task" language doesn't match how that filter is displayed on the newcomer homepage. That being said, I can't really think of better language based on the current filter titles:

Tagging @RHo to update the designs so the copy is finalized. Thanks!

In T324177#8521144, @KStoller-WMF wrote:

I've removed the copy TBC note, as I'm comfortable with the proposed copy:

No suggestions based on your filters
Change your topic and task filters on suggested edits for more articles to edit.

The only note I have is that the "task" language doesn't match how that filter is displayed on the newcomer homepage. That being said, I can't really think of better language based on the current filter titles:

Tagging @RHo to update the designs so the copy is finalized. Thanks!

Hiya - I think we are trialling the new system to update the copy altogether, is that fine to leave copy out of this review and keep with the T324315 task?

In T324177#8523909, @RHo wrote:

In T324177#8521144, @KStoller-WMF wrote:

I've removed the copy TBC note, as I'm comfortable with the proposed copy:

No suggestions based on your filters
Change your topic and task filters on suggested edits for more articles to edit.

The only note I have is that the "task" language doesn't match how that filter is displayed on the newcomer homepage. That being said, I can't really think of better language based on the current filter titles:

Tagging @RHo to update the designs so the copy is finalized. Thanks!

Hiya - I think we are trialling the new system to update the copy altogether, is that fine to leave copy out of this review and keep with the T324315 task?

Yes I think that is fine! So, @KMorgan-WMF you would use the message with the {DRAFT}{UPDATE} prefix (@RHo is that what you want to use for all messages, or would just {DRAFT} suffice?) and add {notranslate} to the end of the relevant qqq.json messages.

In T324177#8533987, @kostajh wrote:

In T324177#8523909, @RHo wrote:

In T324177#8521144, @KStoller-WMF wrote:

I've removed the copy TBC note, as I'm comfortable with the proposed copy:

No suggestions based on your filters
Change your topic and task filters on suggested edits for more articles to edit.

The only note I have is that the "task" language doesn't match how that filter is displayed on the newcomer homepage. That being said, I can't really think of better language based on the current filter titles:

Tagging @RHo to update the designs so the copy is finalized. Thanks!

Hiya - I think we are trialling the new system to update the copy altogether, is that fine to leave copy out of this review and keep with the T324315 task?

Yes I think that is fine! So, @KMorgan-WMF you would use the message with the {DRAFT}{UPDATE} prefix (@RHo is that what you want to use for all messages, or would just {DRAFT} suffice?) and add {notranslate} to the end of the relevant qqq.json messages.

Am I right in assuming we will be creating a new string first? If so, I think {DRAFT} will suffice, and the outdated string can be dealt with separately.

In T324177#8534470, @RHo wrote:

In T324177#8533987, @kostajh wrote:

In T324177#8523909, @RHo wrote:

In T324177#8521144, @KStoller-WMF wrote:

I've removed the copy TBC note, as I'm comfortable with the proposed copy:

No suggestions based on your filters
Change your topic and task filters on suggested edits for more articles to edit.

The only note I have is that the "task" language doesn't match how that filter is displayed on the newcomer homepage. That being said, I can't really think of better language based on the current filter titles:

Tagging @RHo to update the designs so the copy is finalized. Thanks!

Hiya - I think we are trialling the new system to update the copy altogether, is that fine to leave copy out of this review and keep with the T324315 task?

Yes I think that is fine! So, @KMorgan-WMF you would use the message with the {DRAFT}{UPDATE} prefix (@RHo is that what you want to use for all messages, or would just {DRAFT} suffice?) and add {notranslate} to the end of the relevant qqq.json messages.

Am I right in assuming we will be creating a new string first? If so, I think {DRAFT} will suffice, and the outdated string can be dealt with separately.

That's right, we would be creating two new strings. And it doesn't really matter if we use {DRAFT} or {DRAFT}{UPDATE} as the prefix, but I think picking one thing to standardize on and documenting in https://www.mediawiki.org/wiki/Growth/Team/Norms#Translations will be useful. IMO using {DRAFT} as the prefix is sufficient.

In T324177#8534597, @kostajh wrote:

In T324177#8534470, @RHo wrote:

In T324177#8533987, @kostajh wrote:

Yes I think that is fine! So, @KMorgan-WMF you would use the message with the {DRAFT}{UPDATE} prefix (@RHo is that what you want to use for all messages, or would just {DRAFT} suffice?) and add {notranslate} to the end of the relevant qqq.json messages.

Am I right in assuming we will be creating a new string first? If so, I think {DRAFT} will suffice, and the outdated string can be dealt with separately.

That's right, we would be creating two new strings. And it doesn't really matter if we use {DRAFT} or {DRAFT}{UPDATE} as the prefix, but I think picking one thing to standardize on and documenting in https://www.mediawiki.org/wiki/Growth/Team/Norms#Translations will be useful. IMO using {DRAFT} as the prefix is sufficient.

Sounds good to me. I've updated the mocks and copy spreadsheet to remove {UPDATE}. Thanks!

Change 882774 had a related patch set uploaded (by KMorgan; author: KMorgan):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

https://gerrit.wikimedia.org/r/882774

@KStoller-WMF should this dialog be shown only to users who are in the new impact module group? If so, @KMorgan-WMF, we'll need to update the patch to use a feature flag.

Hmmm, I suppose we should just include all Leveling Up changes in the experiment group, right? Sorry, I suppose I should have included that in the acceptance criteria for all of these tasks.

@nettrom_WMF - any thoughts on the feature flag implementation?

In T324177#8570637, @KStoller-WMF wrote:

@nettrom_WMF - any thoughts on the feature flag implementation?

While I think this is an improvement that could benefit everyone since we show tasks in the post-edit dialogue already, I think it shifts the message in the dialogue more towards what Levelling Up aims for. I think we should put it behind the feature flag during the experiment. Since the experiment is time-limited, it won't stay hidden forever either.

I created the task (and patches) for the feature flag in T328757: Leveling up: Define feature flag for gating the functionality

Change 892618 had a related patch set uploaded (by KMorgan; author: KMorgan):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

https://gerrit.wikimedia.org/r/892618

Change 882774 abandoned by KMorgan:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

Reason:

Broke git somehow, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/892618/ for new patch

https://gerrit.wikimedia.org/r/882774

Change 892621 had a related patch set uploaded (by KMorgan; author: KMorgan):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

https://gerrit.wikimedia.org/r/892621

Change 892618 abandoned by KMorgan:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

Reason:

Third time's the charm. Go here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/892621

https://gerrit.wikimedia.org/r/892618

Change 895133 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] i18n: Add messages for post-edit variant

https://gerrit.wikimedia.org/r/895133

Change 895133 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Add messages for post-edit variant

https://gerrit.wikimedia.org/r/895133

@Etonkovidova QA notes: the user has to be in the control variant and be on a wiki where leveling up features are enabled. Then you need to find a task + topic combination where there is one task; once you complete that task, you should see the updated copy +icon if you are in the leveling up group, otherwise you'd see the old copy + icon.

Change 892621 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: Change post-edit no suggestions message

https://gerrit.wikimedia.org/r/892621

In T324177#8680392, @kostajh wrote:

@Etonkovidova QA notes: the user has to be in the control variant and be on a wiki where leveling up features are enabled. Then you need to find a task + topic combination where there is one task; once you complete that task, you should see the updated copy +icon if you are in the leveling up group, otherwise you'd see the old copy + icon.

Thank you, @kostajh!

• The image displayed in the No suggestions dialog seems not to be scaled correctly (or I missed the change of the img requirement) , so only the portion of the image is displayed:

mockup	betalabs

• Checked for accessibility - no new accessibility issues were reported.

Change 897840 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Adjust display of no-results image

https://gerrit.wikimedia.org/r/897840

In T324177#8684533, @Etonkovidova wrote:

• The image displayed in the No suggestions dialog seems not to be scaled correctly (or I missed the change of the img requirement) , so only the portion of the image is displayed:

mockup	betalabs

Thanks for catching that; fixed in https://gerrit.wikimedia.org/r/897840.

Change 897840 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] PostEditPanel: Adjust display of no-results image

https://gerrit.wikimedia.org/r/897840

@kostajh - the post-edit dialog doesn't display the content (the same behavior is on mobile):

For other cases - when there are more suggestions in the queue, the post-edit dialog is displayed correctly.

In T324177#8690014, @Etonkovidova wrote:

@kostajh - the post-edit dialog doesn't display the content (the same behavior is on mobile):

For other cases - when there are more suggestions in the queue, the post-edit dialog is displayed correctly.

That is probably is fallout from the implementation of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel which got merged after this task was completed. I've made a follow-up task: T331980: Post edit dialog: "No suggestions" content does not display

In T324177#8691175, @kostajh wrote:

In T324177#8690014, @Etonkovidova wrote:

@kostajh - the post-edit dialog doesn't display the content (the same behavior is on mobile):

For other cases - when there are more suggestions in the queue, the post-edit dialog is displayed correctly.

That is probably is fallout from the implementation of rEGREf323bd17781e: Post edit panel: do not wait for tasks request to show the panel which got merged after this task was completed. I've made a follow-up task: T331980: Post edit dialog: "No suggestions" content does not display

that is fixed now (see T331980), moving this back to QA.