Why is text inside Phonos buttons styled with dotted underlines? If it's because {{IPAc-en}} does it, that's telling the reader "you can hover your mouse over here to see more info", mimicking the MW styling for <abbr> (IPAc-en provides tooltips explaining the characters unlike other IPA templates). The dotted underlines in Phonos are confusing given what it's already used by MW to communicate (viz. tooltip).
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| PhonosButton.less: remove text decoration from label | mediawiki/extensions/Phonos | master | +0 -2 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 879593 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/Phonos@master] PhonosButton.less: remove text decoration from label
Comment Actions
I'm not sure if we should still include an underline? Technically the button is still a link.
Comment Actions
FWIW enwp goes out of its way to remove underlines from links in .IPA, presumably to avoid interference with descenders (which is why IPAc-en uses border-bottom). enwp won't likely be putting transcriptions inside Phonos buttons, but either way I find underlines overkill (they show up only on hover by default for normal links after all).
I for one think it should be just like {{Audio}}: blue text, no underlines. Blue text is already used during playback, so we'd need another way to convey "progressive", but I've got another idea for that (T326828).
Comment Actions
Change 879593 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] PhonosButton.less: remove text decoration from label
Comment Actions
@MusikAnimal sorry, I just merged your patch because it was in my list on Gerrit, but now I noticed that you'd not put it up for review here yet. Sorry if it wasn't ready! Looks good to me though.
Comment Actions
I don't see underlining in IPA labels on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Phonos).
This is with the exception of when the label transcludes a template which has its own underlining (e.g. see https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Labels4). This seems desirable behaviour to me.
Moving into Product Sign-off. I hope @MusikAnimal had nothing else they wanted to do with this.
Test environment: https://en.wikipedia.beta.wmflabs.org Phonos 0.1.0 (5c828aa) 07:29, 16 January 2023.
Comment Actions
It was ready for review! I just forgot to move it to the right column on Phab. Thanks for merging :)