[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T321620

Kebab menu on Special:MyEvents not working
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Go to Special:MyEvents
  • Open the kebab menu (3 dots) for any event
  • Click "Close registration"

Expected: It should open a popup
Actual: You're sent to Special:EditEventRegistration, which is the no-JS fallback

Note: there are a couple errors in the console that are likely causing this:

Failed to load resource: the server responded with a status of 400 (Bad Request)
VM31:61 {"messageTranslations":{"en":"Mandatory field \"timezone\" missing from request body."},"httpCode":400,"httpReason":"Bad Request"}

Other options in the same menu that require JavaScript are equally broken.

Details

SubjectRepoBranchLines +/-
Fix kebab menu options on firefoxmediawiki/extensions/CampaignEventsmaster+14 -5
Pass 'timezone' to the "edit event registration" endpoint on MyEventsmediawiki/extensions/CampaignEventsmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 25 2022, 8:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2022, 8:10 PM
Daimona claimed this task.Oct 25 2022, 8:10 PM
Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
Daimona updated the task description. (Show Details)
gerritbot added a comment.Oct 25 2022, 8:18 PM

Change 849167 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Pass 'timezone' to the "edit event registration" endpoint on MyEvents

https://gerrit.wikimedia.org/r/849167

gerritbot added a project: Patch-For-Review.Oct 25 2022, 8:18 PM
Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 25 2022, 8:19 PM
Daimona updated the task description. (Show Details)Oct 25 2022, 8:41 PM
gerritbot added a comment.Oct 28 2022, 1:27 PM

Change 849167 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Pass 'timezone' to the "edit event registration" endpoint on MyEvents

https://gerrit.wikimedia.org/r/849167

Daimona mentioned this in rUCAM01397f612c5b: Pass 'timezone' to the "edit event registration" endpoint on MyEvents.Oct 28 2022, 1:27 PM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 28 2022, 1:28 PM
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 28 2022, 2:00 PM
vaughnwalters subscribed.Oct 28 2022, 3:36 PM

Heya @Daimona the bubble notification is now displaying - this is what you meant by "a popup", correct?

Screen Recording 2022-10-28 at 10.32.37 AM.gif (1×2 px, 1 MB)

Daimona added a comment.Oct 28 2022, 3:37 PM
In T321620#8353127, @vaughnwalters wrote:

Heya @Daimona the bubble notification is now displaying - this is what you meant by "a popup", correct?

Yep, I got confused with the "delete registration" option that opens a confirmation dialog. But now it's working as intended AFAICS.

vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 28 2022, 3:51 PM

@Daimona On Firefox, when I close an event that is not in the same wiki (on en wiki, try to close an event in ar wiki) it displays the bubble notification that says it is closed, but then redirects me to the link that says to edit it on the wiki where it was created (so does not actually close the event).

Screen Recording 2022-10-28 at 10.46.07 AM.gif (1×2 px, 1011 KB)

vaughnwalters moved this task from Product sign-off 🤘 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 28 2022, 3:52 PM
Daimona added a comment.Oct 28 2022, 4:11 PM
In T321620#8353185, @vaughnwalters wrote:

@Daimona On Firefox, when I close an event that is not in the same wiki (on en wiki, try to close an event in ar wiki) it displays the bubble notification that says it is closed, but then redirects me to the link that says to edit it on the wiki where it was created (so does not actually close the event).

That's a separate issue, but I'm working on a fix.

gerritbot added a comment.Oct 28 2022, 4:24 PM

Change 850521 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix kebab menu options on firefox

https://gerrit.wikimedia.org/r/850521

gerritbot added a project: Patch-For-Review.Oct 28 2022, 4:24 PM
Daimona moved this task from QA 🐛 to Code Review 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 28 2022, 4:24 PM
gerritbot added a comment.Oct 31 2022, 7:38 AM

Change 850521 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix kebab menu options on firefox

https://gerrit.wikimedia.org/r/850521

Daimona mentioned this in rUCAMea83e7d1fb65: Fix kebab menu options on firefox.Oct 31 2022, 7:38 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 31 2022, 8:30 AM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 31 2022, 12:02 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Oct 31 2022, 7:49 PM
vaughnwalters added a subscriber: ifried.

This a is functioning correctly now, including in firefox. I am moving this to product sign off. Note to @ifried for when you check this out that it opens a bubble notification not a confirmation dialog popup, so slight difference from the AC. but is functioning as expected.

Screen Recording 2022-10-28 at 10.32.37 AM.gif (1×2 px, 1 MB)

ifried closed this task as Resolved.Nov 1 2022, 4:57 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Looks good when I tested on the beta cluster, so marking this as Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits