Flaky tests in test class Wikibase\Repo\Tests\Store\Sql\WikiPageEntityMetaDataLookupTest
Open, HighPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Oct 24 2022, 8:33 PM

Description

Core fails with a Wikibase related test on patch set https://gerrit.wikimedia.org/r/c/mediawiki/core/+/848478
https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php74-docker/1736/console

1) Wikibase\Repo\Tests\Store\Sql\WikiPageEntityMetaDataLookupTest::testLoadRevisionInformationById_masterFallback
Trying to get property 'rev_id' of non-object

/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php:214
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:517

The test is flaky, also seen on some extensions (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParserFunctions/+/845525 / https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php74-docker/2232/console)

Also seen - on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/845696 / https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php74-docker/2320/console

1) Wikibase\Repo\Tests\Store\Sql\WikiPageEntityMetaDataLookupTest::testLoadLatestRevisionIds
Failed asserting that 68 matches expected false.

/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php:414
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php:441
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:517

Details

	Subject	Repo	Branch	Lines +/-
	Temporarily skip flapping test case	mediawiki/extensions/Wikibase	master	+2 -0

Customize query in gerrit

Event Timeline

Umherirrender created this task.Oct 24 2022, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2022, 8:33 PM

Maintenance_bot added a project: Wikidata.Oct 24 2022, 8:45 PM

Showing up on https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/838926 today.

This is becoming a bit of a nuisance so I think this test should be skipped for now.

+1 please skip, this is affecting our work as well.

We're seeing flapping from another test in that class:

14:58:46 1) Wikibase\Repo\Tests\Store\Sql\WikiPageEntityMetaDataLookupTest::testLoadRevisionInformation
14:58:46 Trying to get property 'rev_id' of non-object

I suggest we skip the entire class until it can be fixed.

Change 849468 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Wikibase@master] Temporarily skip flapping test case

https://gerrit.wikimedia.org/r/849468

gerritbot added a project: Patch-For-Review.Oct 26 2022, 8:06 AM

Change 849468 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Temporarily skip flapping test case

https://gerrit.wikimedia.org/r/849468

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 26 2022, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2022, 11:30 AM

Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.Oct 26 2022, 5:03 PM

Lucas_Werkmeister_WMDE subscribed.