[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T316388

Mobile sections on talk page display edit links even when headings are template generated, and not editable
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Esanders
Authored By
stjn
Aug 26 2022, 5:42 PM
Tags
Referenced Files
F37739879: Screenshot 2023-09-19 at 17.53.40.png
Sep 19 2023, 4:54 PM
F37739881: Screenshot 2023-09-19 at 17.54.08.png
Sep 19 2023, 4:54 PM
F37718274: Screenshot 2023-09-13 at 16.05.16.png
Sep 13 2023, 3:06 PM
Subscribers
Aklapper
DLynch
EAkinloose
Izno
Jdlrobson
matmarex
stjn
Tacsipacsi

Description

Updated after DiscussionTools mobile deployment

Steps to replicate the issue (include links if applicable):

The rationale:
This bug prevents me from using <h2> in future version of welcome template in Russian Wikipedia. I want to make it accessible to mobile users, but it seems like the mobile sections only work if you mark up the section with == … ==. That causes another issue for desktop users, since it makes the section display an [edit] link that would confuse new users because it goes to a (full-protected) template.

The ideal solution for my use case would be to show the zero section to mobile users, but I’m not sure if that is even in the plans, so at least this bug needs to be fixed so I can provide a good enough experience both on desktop and mobile. (Right now I am considering to hide the edit link with TemplateStyles, but that might possibly open its own can of worms if <templatestyles> would be before the heading.)

Details

SubjectRepoBranchLines +/-
Hide ellipsis menu when the section is uneditablemediawiki/extensions/DiscussionToolsmaster+410 -389
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Aug 26 2022, 5:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2022, 5:42 PM
Izno subscribed.EditedAug 26 2022, 5:44 PM

T312309: Unify experience for making lead section content available on mobile talk pages may correct the root issue.

Jdlrobson renamed this task from Mobile sections do not open if headings are marked with <h2> to Mobile sections on talk page do not open if headings are marked with <h2>.Aug 30 2022, 3:11 AM
Jdlrobson added projects: Talk Pages, DiscussionTools.
DLynch subscribed.Aug 30 2022, 3:39 PM

Not a DiscussionTools bug per-se? (Unless our changes caused it, of course.) It works in DiscussionTools mode, just not in legacy talk-overlay mode.

matmarex removed a project: Talk Pages.Sep 8 2022, 4:50 PM
matmarex removed a project: DiscussionTools.Sep 8 2022, 5:20 PM
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.
Jdlrobson changed the task status from Open to Stalled.Sep 8 2022, 11:32 PM
Jdlrobson edited projects, added MobileFrontend (Tracking); removed MobileFrontend.
Jdlrobson subscribed.

There were various issues with certain IDs (I imagine it's the "!" character in this case). My understanding is the long-term goal/strategy around these bugs is to remove this feature altogether and replace it with discussion tools so marking as stalled for now.

stjn added a comment.Sep 9 2022, 9:21 AM

I mean, if the problem is in encoding and not in <h2>, then it would’ve definitely needed to be fixed, since I imagine ! and ? characters are used quite a lot in discussions. I don’t think that’s the issue, though, since this talk page experience works fine:
https://en.m.wikipedia.org/wiki/User_talk:Craytonconstanceb

Also, despite DiscussionTools replacing talk pages in Wikipedia, there are still wikis that use MobileFrontend without them right now and that might have the same problem, so if it’s simple enough of a bug to fix, I don’t see how waiting until DT team finishes up with everything is beneficial. I’m updating Welcome template code today to make it more accommodating to mobile users, and at the moment I have to use the workaround that makes the experience for non-mobile users a bit worse so that the template would work fine for everyone.

stjn changed the task status from Stalled to Open.Jun 30 2023, 4:47 AM
stjn added a project: DiscussionTools.

Post-DiscussionTools situation: while the new talk pages are almost perfect, the emphasis is on ‘almost’:
https://ru.m.wikipedia.org/wiki/Обсуждение_участника:Babel_AutoCreate?uselang=en (see first section)

DiscussionTools should not render ‘Edit’ link where it cannot appear on desktop, it gets broken and doesn’t do anything other than closing the section. Re-opening so maybe DiscussionTools team can take a look at it and maybe-maybe fix that (will edit description).

stjn renamed this task from Mobile sections on talk page do not open if headings are marked with <h2> to Mobile sections on talk page display edit links if headings are marked with <h2>.Jun 30 2023, 4:49 AM
stjn updated the task description. (Show Details)
ppelberg added a project: Editing-team (Kanban Board).Aug 24 2023, 3:28 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
Tacsipacsi subscribed.Aug 24 2023, 5:43 PM

Interesting, it seems to happen only with MobileFrontend + Minerva, not with either of them alone:

Esanders renamed this task from Mobile sections on talk page display edit links if headings are marked with <h2> to Mobile sections on talk page display edit links even when headings are template generated, and not editable.Aug 25 2023, 3:13 PM
gerritbot added a comment.Aug 25 2023, 3:23 PM

Change 952468 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Hide ellipsis menu when the section is uneditable

https://gerrit.wikimedia.org/r/952468

gerritbot added a project: Patch-For-Review.Aug 25 2023, 3:23 PM
Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Aug 25 2023, 5:27 PM
Esanders claimed this task.Sep 5 2023, 2:07 PM
gerritbot added a comment.Sep 5 2023, 10:44 PM

Change 952468 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Hide ellipsis menu when the section is uneditable

https://gerrit.wikimedia.org/r/952468

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 5 2023, 10:46 PM
matmarex added a project: Editing QA.
matmarex subscribed.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 5 2023, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 11:10 PM
EAkinloose subscribed.Sep 13 2023, 3:06 PM

@Esanders, In trying to test this, the Edit button does not do anything. Nothing in the console as well.

However, the desktop does not show the [edit] link as expected

Screenshot 2023-09-13 at 16.05.16.png (574×2 px, 157 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Sep 19 2023, 4:54 PM

No affordance for edit is displayed

Screenshot 2023-09-19 at 17.54.08.png (536×1 px, 152 KB)
Screenshot 2023-09-19 at 17.53.40.png (322×630 px, 42 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 19 2023, 4:54 PM
ppelberg closed this task as Resolved.Sep 19 2023, 11:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits