[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T316840

Don't tokenize cards when donation is under Monthly Convert minimum
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Even when Monthly Convert would otherwise be on, don't tokenize the card when the donation is under the minimum amount.

I think we can do this by adding an amount check to the showMonthlyConvert function that looks at the wgDonationInterfaceMonthlyConvertAmounts setting

Details

SubjectRepoBranchLines +/-
Don't tokenize cards when donation is under Monthly Convert minimummediawiki/extensions/DonationInterfacemaster+159 -65
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Aug 31 2022, 10:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2022, 10:42 PM
Ejegg mentioned this in T313854: Adyen donors think they are recurring July 2022.Sep 1 2022, 7:26 PM
XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 6 2022, 6:36 PM
Dwisehaupt set the point value for this task to 2.Sep 8 2022, 4:18 PM
Ejegg added a project: Fundraising Sprint Quarkery.Sep 14 2022, 1:33 PM
Ejegg moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Sep 14 2022, 1:34 PM
Damilare claimed this task.Sep 14 2022, 3:51 PM
Damilare moved this task from Backlog to Doing on the Fundraising Sprint Quarkery board.
gerritbot added a comment.Sep 15 2022, 3:26 PM

Change 832508 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] Don't tokenize cards when donation is under Monthly Convert minimum

https://gerrit.wikimedia.org/r/832508

gerritbot added a project: Patch-For-Review.Sep 15 2022, 3:26 PM
Damilare moved this task from Doing to Review on the Fundraising Sprint Quarkery board.Sep 16 2022, 12:54 AM
AnnWF moved this task from Review to Pending Deployment on the Fundraising Sprint Quarkery board.Sep 20 2022, 10:16 PM
gerritbot added a comment.Sep 22 2022, 5:43 PM

Change 832508 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Don't tokenize cards when donation is under Monthly Convert minimum

https://gerrit.wikimedia.org/r/832508

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 22 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2022, 6:30 PM
XenoRyet added a project: Fundraising Sprint Recursion Excursion.Sep 27 2022, 8:24 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Recursion Excursion board.Sep 28 2022, 12:33 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Recursion Excursion board.Oct 4 2022, 7:23 PM
XenoRyet closed this task as Resolved.Oct 11 2022, 7:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits