[go: up one dir, main page]

Page MenuHomePhabricator

Menus display unnecessary margin in Codex demo
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Open the page dedicated to Menu in Codex's demo site
  • Activate the first input to trigger the 'Simple menu with input' example
  • Inspect the second, third, or fourth <li> elements in the unordered list that constitutes the menu

What happens?:

Inspection allows detecting that all the <li>s in the Menu component (except the first one) have a top margin of 8px applied to them via the selector .vp-doc li+li. The issue therefore affects all the menus in the entire demo page that contain more than one item. Some examples:

Screenshot 2022-08-29 at 11.51.44.png (331×1 px, 94 KB)
Screenshot 2022-08-29 at 11.54.12.png (372×1 px, 134 KB)
Screenshot 2022-08-29 at 11.56.28.png (817×1 px, 326 KB)

What should have happened instead?:

That extra margin-top shouldn't be applied to menu elements: these should be only spaced by their padding.

Other information:

Issue found using Chrome v104 on macOS Monterey. Persistency checked using Firefox 103 and Safari 15.6

Event Timeline

Change 828028 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] docs: Remove VitePress list style in the demo pane

https://gerrit.wikimedia.org/r/828028

Change 828028 merged by jenkins-bot:

[design/codex@main] docs: Remove VitePress list style in the demo pane

https://gerrit.wikimedia.org/r/828028

Change 828083 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.1.0-alpha.10 to v0.1.0

https://gerrit.wikimedia.org/r/828083

Change 828083 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.1.0-alpha.10 to v0.1.1

https://gerrit.wikimedia.org/r/828083

The problem appears to be solved! Thanks, Anne.

Verified using Chrome v105, Safari 15.6 and Firefox 104 all on macOS Monterey.

Volker_E reassigned this task from DAbad to AnneT.
Volker_E added subscribers: DAbad, Volker_E.

Become part of Codex in v0.1.1.