[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T315108

Add extra translations for adyen gpay button
Closed, ResolvedPublic
Actions

Description

Add translations for the "Donate with Gpay" button for hebrew and norwegian (nb)

Currently we use https://developers.google.com/pay/api/web/reference/request-objects#ButtonOptions local to control the language, but the translation is handled by gpay itself
Supported locales include en, ar, bg, ca, cs, da, de, el, es, et, fi, fr, hr, id, it, ja, ko, ms, nl, no, pl, pt, ru, sk, sl, sr, sv, th, tr, uk, and zh

reference: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/755523

Details

SubjectRepoBranchLines +/-
Show plain GPay button rather than wrong languagemediawiki/extensions/DonationInterfacemaster+16 -4
Adyen: extract i18n function, map nb->nomediawiki/extensions/DonationInterfacemaster+48 -37
Customize query in gerrit

Event Timeline

AnnWF created this task.Aug 12 2022, 7:00 PM
Restricted Application added subscribers: jhsoby, Aklapper. · View Herald TranscriptAug 12 2022, 7:00 PM
XenoRyet added a project: Fundraising Tech - Chaos Crew.Aug 12 2022, 7:01 PM
• TSkaff subscribed.Aug 12 2022, 7:05 PM
HNordeenWMF added a subscriber: Pcoombe.Aug 12 2022, 7:25 PM
HNordeenWMF subscribed.EditedAug 12 2022, 7:32 PM

thanks! the dream is to test GPay in these languages next week.

Norwegian translation for nb (copy over the one used for "no"): Donér med %GPay logo%.
Hebrew translation: %GPay logo% לתרום עם

HNordeenWMF renamed this task from Add extra translation for adyen gpay button to Add extra translations for adyen gpay button.Aug 12 2022, 8:01 PM
greg triaged this task as High priority.Aug 12 2022, 8:40 PM
Ejegg subscribed.Aug 15 2022, 3:22 PM

So if Adyen and GPay don't support 'nb' I suggest we set 'no' as the locale for their components whenever we get 'nb' from banners.

Ejegg claimed this task.Aug 15 2022, 3:43 PM
Ejegg moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
gerritbot added a comment.Aug 15 2022, 4:02 PM

Change 823180 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Adyen: extract i18n function, map nb->no

https://gerrit.wikimedia.org/r/823180

gerritbot added a project: Patch-For-Review.Aug 15 2022, 4:02 PM
Ejegg added a comment.Aug 15 2022, 4:14 PM

@HNordeenWMF I don't actually see a way to set custom text on the GPay button (e.g. to provide text for Hebrew). It will fall back to whichever supported language the donor has set as their next preference in their browser language preferences (or English if there's no supported fallback).

If that's unacceptable, the best we can do would be to use the plain GPay logo button with no 'donate' text for unsupported locales. Should we do that?

HNordeenWMF added a comment.EditedAug 15 2022, 5:24 PM

thanks Elliott! Documenting the decision from standup:
Use the plain GPay logo button with no 'donate' text for unsupported locales!

Ejegg added a comment.Aug 15 2022, 6:56 PM

OK, we're going ahead with the plain GPay button for languages not on that list. The good news is that all the popup text is translated into Hebrew:

image.png (667×593 px, 39 KB)

gerritbot added a comment.Aug 15 2022, 7:00 PM

Change 823202 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Show plain GPay button rather than wrong language

https://gerrit.wikimedia.org/r/823202

XenoRyet moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Aug 15 2022, 7:33 PM
gerritbot added a comment.Aug 15 2022, 8:32 PM

Change 823180 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Adyen: extract i18n function, map nb->no

https://gerrit.wikimedia.org/r/823180

gerritbot added a comment.Aug 15 2022, 8:32 PM

Change 823202 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Show plain GPay button rather than wrong language

https://gerrit.wikimedia.org/r/823202

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 15 2022, 9:00 PM
Ejegg moved this task from In Progress to Completed 20220830 - 20220913 on the Fundraising Tech - Chaos Crew board.Aug 15 2022, 9:23 PM

@HNordeenWMF this is deployed. The changes are in javascript, so you might have to hard-reload the payments form to see them. The nb-language payments form now shows 'Donér med' and the he-language payments form now shows the plain 'GPay' button.

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 9:30 PM
Ejegg added a comment.Aug 15 2022, 9:32 PM

@HNordeenWMF oooops, that's breaking the card form. rolling back!

Ejegg added a comment.Aug 15 2022, 9:36 PM

@HNordeenWMF false alarm, the card form was only breaking when I had debug=true on the URL. This has been known to break payments-wiki forever. The GPay language fixes are deployed and the card form is working fine too.

HNordeenWMF added a comment.Aug 15 2022, 10:12 PM

Woot, thanks so much @Ejegg !

XenoRyet closed this task as Resolved.Aug 16 2022, 7:12 PM
XenoRyet set Final Story Points to 2.
greg moved this task from Completed 20220830 - 20220913 to Completed 20220802 - 20220816 on the Fundraising Tech - Chaos Crew board.Aug 16 2022, 7:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits