[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T315863

Table of contents doesn't respect NOTOC after an edit
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to ____
  • Add __NOTOC__ to the page and hit save

What happens?:
Expected: table of contents disappears

What should have happened instead?:
Actual: table of contents reappears. After reloading the page it disappears.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T315863#8196907
2✅T315863#8196907

QA Results - Prod

ACStatusDetails
1✅T315863#8203277
2✅T315863#8203277

Details

SubjectRepoBranchLines +/-
Table of contents doesn't respect NOTOC after an editmediawiki/skins/Vectormaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 22 2022, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2022, 10:01 AM
Jdlrobson mentioned this in T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).Aug 22 2022, 10:04 AM
Jdlrobson added a subscriber: matmarex.
In T307251#8170130, @matmarex wrote:

Not that I know of, but I don't think this matters here. The bug also occurs when the table of contents is forced on or off using __TOC__ / __NOTOC__ magic words, or in visual editor's page options:

image.png (2×3 px, 1 MB)

Presumably our wikipage.tableOfContents hook should not fire in the case of NOTOC (https://gerrit.wikimedia.org/g/mediawiki/core/+/c7099b957afae584dfdd4c2a0c814ca847bd4763/resources/src/mediawiki.page.preview.js#179). Can we get the value of the NOTOC flag from the parser result?

ovasileva triaged this task as High priority.Aug 22 2022, 11:07 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.
JJMC89 updated the task description. (Show Details)Aug 22 2022, 3:48 PM
ppelberg subscribed.Aug 22 2022, 4:06 PM
matmarex added a comment.Aug 22 2022, 6:36 PM
In T315863#8173345, @Jdlrobson wrote:

Presumably our wikipage.tableOfContents hook should not fire in the case of NOTOC (https://gerrit.wikimedia.org/g/mediawiki/core/+/c7099b957afae584dfdd4c2a0c814ca847bd4763/resources/src/mediawiki.page.preview.js#179). Can we get the value of the NOTOC flag from the parser result?

Yes and yes, it already does that. See the check for response.parse.hidetoc in the code you linked to. wikipage.tableOfContents is fired with an empty array if the TOC is not supposed to be displayed, but Vector still displays an empty TOC with a "Beginning" link.

Jdlrobson renamed this task from Table of contents doesn't respect NOTOC to Table of contents doesn't respect NOTOC after an edit.Aug 23 2022, 5:27 PM
ovasileva assigned this task to • Mabualruz.Aug 23 2022, 5:29 PM
gerritbot added a comment.Aug 25 2022, 12:07 PM

Change 826551 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Table of contents doesn't respect NOTOC after an edit

https://gerrit.wikimedia.org/r/826551

gerritbot added a project: Patch-For-Review.Aug 25 2022, 12:07 PM
• Mabualruz moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 25 2022, 12:13 PM
• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
• Mabualruz moved this task from Code Review to Needs Analysis on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 25 2022, 12:20 PM
Jdlrobson moved this task from Needs Analysis to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 26 2022, 2:42 PM
gerritbot added a comment.Aug 26 2022, 6:59 PM

Change 826551 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Table of contents doesn't respect NOTOC after an edit

https://gerrit.wikimedia.org/r/826551

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2022, 7:31 PM
Jdlrobson reassigned this task from • Mabualruz to Edtadros.Aug 29 2022, 4:12 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson added a subscriber: • Mabualruz.
LGoto set the point value for this task to 3.Aug 29 2022, 5:46 PM
Jdlrobson mentioned this in T315862: Table of contents doesn't update correctly on pages with < 4 sections.Aug 29 2022, 5:46 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 30 2022, 2:02 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Edit the source of an article
Add NOTOC to the page and hit save
✅ AC1: The table of contents disappears
Remove NOTOC
✅ AC2: The table of contents reappears

Screen Recording 2022-08-29 at 6.58.12 PM.mov.gif (898×1 px, 3 MB)

Edtadros reassigned this task from Edtadros to ovasileva.EditedAug 31 2022, 4:46 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Edit the source of an article
Add NOTOC to the page and hit save
✅ AC1: The table of contents disappears

Remove NOTOC
✅ AC2: The table of contents reappears

Screen Recording 2022-08-31 at 9.43.21 AM.mov.gif (966×1 px, 3 MB)

Edtadros updated the task description. (Show Details)Aug 31 2022, 4:49 PM
ovasileva closed this task as Resolved.Sep 1 2022, 8:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits