[Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs
Closed, ResolvedPublic4 Estimated Story PointsFeature
Actions

Description

Feature summary (what you would like to be able to do and where):

Special:CentralNotice currently replaces the namespaces tabs on its special pages with 2 links via hook. In the future this will not be supported.
This is the hook in question:
https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/2f02da42d990f4e5596c643721aaf18450482d38/extension.json#315

The links in question look like this:

In T313349 we made it possible for special pages to register menus. This will soon be added to Minerva and Vector 2022 skins.
Please see example link here:
https://gerrit.wikimedia.org/r/c/816211

TODO

Implement the methods SpecialPageCentralNotice::getShortDescription and SpecialPageCentralNotice::getAssociatedNavigationLinks as in the example in https://gerrit.wikimedia.org/r/c/816211, following the logic in the hook https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/2f02da42d990f4e5596c643721aaf18450482d38/extension.json#315
Update the hook https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralNotice/+/2f02da42d990f4e5596c643721aaf18450482d38/extension.json#315 to return when Skin::supportsMenu( 'associated-pages' ) is truthy

Details

	Subject	Repo	Branch	Lines +/-
	On admin interface, use nav links if supported	mediawiki/extensions/CentralNotice	master	+35 -0

Customize query in gerrit

Related Objects

Mentioned In: T316818: Watchlist uses non-standard submenu for tabs which doesn't display on mobile web
Mentioned Here: T313349: Allow special pages to register navigation links in skins

Event Timeline

Jdlrobson created this task.Aug 18 2022, 2:18 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 18 2022, 2:18 PM

Jdlrobson moved this task from Backlog to Migrate the things on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Aug 18 2022, 9:31 PM

Jdlrobson updated the task description. (Show Details)Aug 30 2022, 9:37 PM

Jdlrobson mentioned this in T316818: Watchlist uses non-standard submenu for tabs which doesn't display on mobile web.Aug 31 2022, 8:40 PM

AndyRussG added a project: Fundraising-Backlog.Sep 1 2022, 2:16 PM

XenoRyet moved this task from Triage to Later on the Fundraising-Backlog board.Sep 6 2022, 6:41 PM

Dwisehaupt set the point value for this task to 4.Sep 9 2022, 4:34 PM

Jdlrobson moved this task from Menus 2.0 to Contributions entry point on the MediaWiki-Core-Skin-Architecture board.Nov 15 2022, 4:51 PM

Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed MediaWiki-Core-Skin-Architecture (Menus 2.0).

Could this be prioritized fundraising team? I'm happy to help if it's not clear what this task is about.

AndyRussG_volunteer claimed this task.Jun 14 2023, 10:00 PM

Change 934428 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/CentralNotice@master] On admin interface, use nav links if supported

https://gerrit.wikimedia.org/r/934428

gerritbot added a project: Patch-For-Review.Jun 30 2023, 2:16 AM

Instructions for testing on FR-Tech Docker:

No change under classic Vector skin (which is currently still default on Meta):
https://localhost:9010/wiki/Special:CentralNotice

Navigation links under Vector 2022:
https://localhost:9010/wiki/Special:CentralNotice?useskin=vector-2022

Navigation links under Mobile skin (requires updating Docker setup):
https://localhost:9010/wiki/Special:CentralNotice?useskin=minerva

For the last two links, be sure to re-add the URL parameter after clicking on the navigation link.

(@Jdlrobson I'm not sure why I'm getting strange formatting when I use useformat=mobile as the URL parameter, but I assume it's something to do with my local setup, rather than the attached patch.)

Thanks much!!!

Change 934428 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] On admin interface, use nav links if supported

https://gerrit.wikimedia.org/r/934428

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2023, 5:10 PM

@Jdlrobson checking in on this task - was it resolved with the last patch?

LGTM. Thanks for working on this @AndyRussG_volunteer !