Maniphest T314802

[Vue warn]: icon-only buttons require one of the following attribute: aria-label or aria-hidden.
Open, LowPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	Aug 8 2022, 4:38 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog?quicksurvey=true
Open developer console

What happens?:

See developer console warning

What should have happened instead?:

NO warning

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Duplicates Merged Here: T339800: Icon-only dismiss button should have an aria-label

Event Timeline

Jdlrobson created this task.Aug 8 2022, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2022, 4:38 PM

Jdlrobson moved this task from Backlog to Waiting on other teams on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Aug 11 2022, 6:14 PM

Jdlrobson moved this task from Waiting on other teams to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.

This is happening because the close button needs an aria-label (or :aria-hidden="true" if you want to hide it from SRs); see here for more info.

Jdlrobson moved this task from Future Unplanned to Vector code cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 12 2023, 10:05 PM

Jdlrobson moved this task from Vector code cleanup to Onboarding on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 12 2023, 10:08 PM

Jdlrobson triaged this task as Low priority.Mar 15 2023, 10:35 PM

Jdlrobson added projects: patch-welcome, good first task.

Jdlrobson moved this task from Onboarding to deprecations/removals/code simplification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 12 2023, 3:59 PM

Jdlrobson merged a task: T339800: Icon-only dismiss button should have an aria-label.Jun 20 2023, 6:08 PM

Jdlrobson added a subscriber: • Catrope.

Here's an updated link to the guidelines available in the Codex docs on how to address this.

Jdlrobson moved this task from deprecations/removals/code simplification to Backlog on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jul 16 2024, 11:00 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)).Jul 16 2024, 11:20 PM

Jdlrobson moved this task from Needs Prioritization (Tech) to Incoming on the Web-Team-Backlog board.

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Sep 25 2024, 4:25 PM

Jdlrobson edited projects, added Web-Team; removed Web-Team-Backlog.Wed, Nov 13, 11:42 PM

Jdlrobson moved this task from Product Backlog to Legacy backlog on the Web-Team board.Wed, Nov 13, 11:55 PM