| Samwilson | |
| Jul 20 2022, 6:04 AM |
| F35322836: Screenshot 2022-07-20 at 10-49-12 Editing Main Page - Dev wiki1.png | |
| Jul 20 2022, 6:04 AM |
When a non-wrappable element exists in the preview, and its size is reduced below the minimum (248px), the preview contents sticks out beyond the bounds of the preview area:
To reproduce:
Let's point this one, I am down to de-scope if it's an edge case and too expensive, but adding to Pencil's down work for now
Change 816013 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/WikiEditor@master] Realtime Preview: make ResizingDragBar's max width match the CSS
Change 816013 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Realtime Preview: make ResizingDragBar's max width match the CSS
@MusikAnimal The bug I described in T306877#8093774 is still happening for me on beta. On Firefox 91 and Chrome 103. Vector 2022 with the left-menu open.
Ah! When I pulled in the latest for the Vector skin on my local (before I was at 33a6fb60 from June 23), I can now repro. So it's something to do with Vector itself, I think.
I can continue working on this with a separate patch for T306877, but I suppose this task (unless you find otherwise) is OK to move forward.
Edit: I see you already moved T306877 to Product Sign-Off, so I guess we'll use this task. Disregard the above! I'll investigate and comment back here with my findings with respect to the infinite scrolling issue.
Looks like the issue described at T306877#8093774 (now part of this task) was introduced with the new Vector grid system (T312241, enabled with r808258). .mw-content-container now has the CSS rule max-width: none, which as Dom points out is only present when the left sidebar is open in Vector 2022. It also only effects wide viewports as specified by @width-breakpoint-desktop-wide (currently ~1200px).
Now I know the cause, and I'm looking for a solution that doesn't involve overriding anything in Vector.
In the check-in meeting yesterday, @NRodriguez decided the outstanding issue with the infinite scrollability can be deprioritized for now. If it means anything, the older WikiEditor (as well as the default editor in MW) had the same behaviour with the browser's ability to enlarge a textarea. If anyone feels compelled, this issue may deserve a separate task, but this task was about the content extending outside the preview area which has now been fixed. I'm moving this back to QA in case Dom has thoughts or if there's anything else to QA.
With the current WikiEditor and Realtime Preview disabled, I cannot reproduce this issue because I can only increase the vertical size of the editor (including with CodeMirror). Therefore, I only get this issue with Realtime Preview enabled.
If anyone feels compelled, this issue may deserve a separate task, but this task was about the content extending outside the preview area which has now been fixed. I'm moving this back to QA in case Dom has thoughts or if there's anything else to QA.
OK. In that case I have just raised T314467, if someone wants to fix this.
Oh, @MusikAnimal, should you point this task?
With the debugging and such I think this came out to about a 3