| Jdlrobson | |
| Jun 13 2022, 6:41 PM |
| F35251959: Screen Shot 2022-06-18 at 6.17.34 PM.png | |
| Jun 19 2022, 1:23 AM |
| F35251958: Screen Shot 2022-06-18 at 6.17.09 PM.png | |
| Jun 19 2022, 1:23 AM |
| F35251953: Screen Shot 2022-06-18 at 6.13.48 PM.png | |
| Jun 19 2022, 1:15 AM |
| Restricted File | |
| Jun 16 2022, 11:46 AM |
| Restricted File | |
| Jun 15 2022, 4:00 PM |
| F35242960: minerva_alert.png | |
| Jun 15 2022, 8:57 AM |
| F35237123: Screen Shot 2022-06-13 at 11.30.22 AM.png | |
| Jun 13 2022, 6:41 PM |
| F35237181: Screen Shot 2022-06-13 at 11.41.42 AM.png | |
| Jun 13 2022, 6:41 PM |
Expected: the language is localized
Actual:
The language is not localized:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310537#8013308 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310537#8013311 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Notification icon should be localized | mediawiki/skins/MinervaNeue | master | +2 -1 |
Change 805222 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Notification icon should be localized
Change 805222 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Notification icon should be localized
@kostajh web team can handle QA and sign off. Do you think it needs to be backported?
The number is now localized. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?uselang=bn
However, note the number is sometimes inaccurate due to T310559
@Jdlrobson Here is what Minerva looks like on my local docker server, I am not sure what is happening:
thanks!
Do you think it needs to be backported?
It will roll out with wmf.16, so I think it is OK to let it go with the train. However the report in T310537#8004960 is concerning, if that is fallout from this patch.
@dom_walden I am unable to replicate that and not seeing any visual regressions like that on https://pixel.wmcloud.org/reports/echo/index.html. Are you sure you are running the master version of Echo, MobileFrontend and Minerva? (note all 3 of those currently have code relating to Echo)
If so (and you are able to) could you open up the developer tools with the #user-notifications element focused?
{F35244201}
Ah, right. My versions of Echo and MobileFrontend were out-of-date. Here is how it looks now:
{F35246627}
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?uselang=bn
Login
✅ AC1: Confirm the notification count is localized
Status: ✅ PASS
Environment: enwiki, bnwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?uselang=bn
Login
✅ AC1: Confirm the notification count is localized