[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T310491

Don't show table of results on Special:SimilarEditors if there are no similar editors
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reported in T307023#7963123

Currently, if there are no similar editors but the request was successful, we see the table headers:

only_headers.png (505×1 px, 48 KB)

Instead, we should see the message: "There are no results."

Details

SubjectRepoBranchLines +/-
Don't show table if no resultmediawiki/extensions/SimilarEditorsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 13 2022, 1:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2022, 1:49 PM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jun 13 2022, 1:49 PM
Tchanders mentioned this in T307023: Display results of Special:SimilarEditors.Jun 13 2022, 2:20 PM
• AGueyte set the point value for this task to 1.Jun 13 2022, 3:19 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Jun 14 2022, 2:56 PM
ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 10: The Mokorotlo on the Anti-Harassment board.Jun 14 2022, 5:04 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment.
• AGueyte claimed this task.Jun 16 2022, 7:39 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.
gerritbot added a comment.Jun 16 2022, 11:58 PM

Change 806353 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/SimilarEditors@master] Don't show table if no result

https://gerrit.wikimedia.org/r/806353

gerritbot added a project: Patch-For-Review.Jun 16 2022, 11:58 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 17 2022, 12:02 AM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 21 2022, 4:22 PM
gerritbot added a comment.Jun 21 2022, 4:24 PM

Change 806353 merged by jenkins-bot:

[mediawiki/extensions/SimilarEditors@master] Don't show table if no result

https://gerrit.wikimedia.org/r/806353

• AGueyte mentioned this in rESIEe10515d5e77a: Don't show table if no result.Jun 21 2022, 4:25 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 4:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 21 2022, 5:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 22 2022, 7:42 AM
dom_walden subscribed.

Here is what the example from the description looks like now:

no_results_now.png (442×1 px, 40 KB)

I repeated with a number of users and IPs which also had no similar editors.

I also tested a user who did have similar editors to check that the results did show correctly in that case.

Test environment: local docker Similar Editors 0.0.0 (f294db1) 06:13, 22 June 2022.

dom_walden mentioned this in T309232: Similarusers service should check for 'user' key in results returned from Revisions API.Jun 23 2022, 9:01 AM
Niharika closed this task as Resolved.Jul 26 2022, 2:12 PM
dom_walden mentioned this in T311724: Display generic error message on Special:SimilarEditors.Aug 1 2022, 12:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits