Change 805824 had a related patch set uploaded (by MarcoAurelio; author: MarcoAurelio):

[mediawiki/extensions/IPInfo@master] Allow filtering the IPInfo log by type of actions

https://gerrit.wikimedia.org/r/805824

Tested my above patch. The ipinfo logs appears to correctly filter by type of action:

Unfiltered log		Enable/Disable own access
View infobox		View popup

Note: IP addresses displayed there are not real.

Pings to @Tchanders and @Niharika for further review/patch approval if appropriate.

Thanks.

Change 805824 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Allow filtering the IPInfo log by type of actions

https://gerrit.wikimedia.org/r/805824

@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:

[YrXCZWGXEEzZDXncyWtEDQAAAAk] /wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers InvalidArgumentException: Invalid IP address

Backtrace:

from /srv/mediawiki/php-master/includes/user/UserFactory.php(112)
#0 /srv/mediawiki/php-master/extensions/IPInfo/src/Logging/IPInfoLogFormatter.php(34): MediaWiki\User\UserFactory->newAnonymous(string)
#1 /srv/mediawiki/php-master/includes/logging/LogFormatter.php(493): MediaWiki\IPInfo\Logging\IPInfoLogFormatter->getMessageParameters()
#2 /srv/mediawiki/php-master/includes/logging/LogFormatter.php(468): LogFormatter->getActionMessage()
#3 /srv/mediawiki/php-master/includes/logging/LogEventsList.php(383): LogFormatter->getActionText()
#4 /srv/mediawiki/php-master/includes/logging/LogPager.php(451): LogEventsList->logLine(stdClass)
#5 /srv/mediawiki/php-master/includes/pager/ReverseChronologicalPager.php(115): LogPager->formatRow(stdClass)
#6 /srv/mediawiki/php-master/includes/pager/IndexPager.php(634): ReverseChronologicalPager->getRow(stdClass)
#7 /srv/mediawiki/php-master/includes/specials/SpecialLog.php(294): IndexPager->getBody()
#8 /srv/mediawiki/php-master/includes/specials/SpecialLog.php(176): SpecialLog->show(FormOptions, array)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(688): SpecialLog->execute(NULL)
#10 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1418): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(911): MediaWiki->performRequest()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(570): MediaWiki->main()
#14 /srv/mediawiki/php-master/index.php(50): MediaWiki->run()
#15 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}

I have not been able to reproduce this locally yet.

In T309400#8025778, @dom_walden wrote:

@MarcoAurelio Trying to access the IPInfo logs on beta (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers) I get the exception:

Actually, I don't think this is related to this change. Instead, I think it has something to do with T310815. There are records in the logs of IPInfo lookups which are not of actual IP addresses.

Due to the above error I couldn't test this on beta but I have tested it locally.

Here is what the form looks like now:

I looked at the SQL query that was being made when selecting various options from the dropdown.

For the "All" option, the query is exactly the same as the query we used to make before this code change.

Moving to Design Review as @Niharika and @Prtksxna may want to review the exact wording we are using for the dropdown options:

• Type of IPInfo operation:
• Enable or disable of tool
• View of infobox data
• View of popup data

Test environment: local docker IP Info 0.0.0 (f689140) 10:30, 24 June 2022.

Thanks for your tests and comments @dom_walden:

The language was proposed by @STran in the patch (see previous and updated wording side-by-side). If you all think another wording is better, please let me know, I can upload another patch to change it.

I can't reproduce the MW Exception on Meta-Wiki Beta Cluster, where the log and the type selector seems to work fine ( see here); however I am indeed able to reproduce the error you quoted on the enwiki Beta Cluster. I am not sure why though.

Best regards.

In T309400#8026215, @MarcoAurelio wrote:

The language was proposed by @STran in the patch (see previous and updated wording side-by-side). If you all think another wording is better, please let me know, I can upload another patch to change it.

I think they are fine, but I will let @Niharika and @Prtksxna have the final say, just to make sure we are being consistent with our wording.

I can't reproduce the MW Exception on Meta-Wiki Beta Cluster, where the log and the type selector seems to work fine ( see here); however I am indeed able to reproduce the error you quoted on the enwiki Beta Cluster. I am not sure why though.

I think it is because enwiki beta has some rows in the logging table which it should not do (targets which are not IP addresses when it expects them to be), due to T310815. These probably don't exist on other (less commonly used) beta wikis.

In T309400#8028867, @dom_walden wrote:

I think they are fine, but I will let @Niharika and @Prtksxna have the final say, just to make sure we are being consistent with our wording.

Based on the changes we're making in T311683, let's use the "IP Information" for the product name. Let's use the past tense for logged actions:

Change 811665 had a related patch set uploaded (by MarcoAurelio; author: MarcoAurelio):

[mediawiki/extensions/IPInfo@master] i18n: Amend log-action-filter-* messages

https://gerrit.wikimedia.org/r/811665

Change 811665 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] i18n: Amend log-action-filter-* messages

https://gerrit.wikimedia.org/r/811665

The wording has been updated correctly.

Thanks @MarcoAurelio - we can leave this for @Niharika to close