| Keyacom | |
| May 11 2022, 7:17 PM |
| F35131168: image.png | |
| May 11 2022, 7:17 PM |
List of steps to reproduce (step by step, including full links if applicable):
What happens?:
CodeEditor looks broken, as in the screenshot in the last section.
What should have happened instead?:
CodeEditor should have only appeared with a "Preview" button in the top right?
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Realtime preview: allow loading as a gadget | mediawiki/extensions/WikiEditor | master | +10 -2 |
This is actually not the 2017 wikitext editor (see https://www.mediawiki.org/wiki/Editor), but rather the realtime preview tool.
Change 804273 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/WikiEditor@master] Realtime preview: allow loading as a gadget
Change 804273 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Realtime preview: allow loading as a gadget
I don't think there is much I can do to test this at the moment.
As I understand it, this change adds some client-side code that stops RTP from loading when the content type of the page is something other than wikitext (e.g. JS, JSON, etc.) Normally, this would be done server-side, but not when RTP is loaded as a gadget (in which case client-side code is needed).
On beta I can confirm that RTP is still being loaded on several namespaces (Article, File, Template).
It isn't loaded on pages using CodeEditor, but this is because it is being done server-side. To test the client-side code, we would need to load it as a gadget. I am not sure how to do this on beta. It might be easiest to wait for it to be deployed to plwiki and test there. (The same goes for T307039 and T309330.) @Samwilson what do you think?
@dom_walden: Yes, that's correct. Sorry, I should've thought of this before — I've now added it as a default gadget on Beta English Wikisource (e.g.). You'll have to turn off the beta feature.
Or wait till after the train next week and test on plwiki as you say.
I tested a few pages on beta wikisource where the CodeEditor is used (e.g. here, here, here). The Realtime Preview does not get loaded. The regular CodeEditor behaves as I understand it should. All the basic functionality appears to function.