Standardise timestamps globalblocks.gb_expiry/global_block_whitelist.gbw_expiry on GlobalBlocking extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Apr 23 2022, 7:51 PM

Description

According to T42626 the timestamp column should not have a default of the empty string.

This is an invalid type for postgres timestamps

Also for fixed timestamp the column must not variable length.

	Subject	Repo	Branch	Lines +/-
	abstract schema: Use mwtimestamp type for timestamp columns	mediawiki/extensions/GlobalBlocking	master	+358 -14

Mentioned In: T307501: Adjust the field type of globalblocks timestamp columns to fixed binary on wmf wikis
Mentioned Here: T42626: Standardise type of timestamp database fields (MySQL)

Change 785376 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalBlocking@master] abstract schema: Use mwtimestamp type for timestamp columns

Change 785376 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] abstract schema: Use mwtimestamp type for timestamp columns

Umherirrender triaged this task as Low priority.