Change 830202 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] Enable the topic match mode in all wikis

https://gerrit.wikimedia.org/r/830202

@KieranMcCann do we need a different icon state on the Topic filter to show the user that their topic filter is in AND mode?

Compare AND mode:

to OR mode:

As a user, my only visual cue is that the total count is increased.

Reviewing the designs, I think there's already a "hint" icon for the mode (+ sign). At least in mobile design I can see "GLAM Argentina +", although I think a real examples would show "3 Topics +". Checking on the deployed version it's not showing for me.

Maybe we can fix this bug for mobile and apply the same solution for desktop? One thing that bothers me with "3 Topics +" is that it can be read as "more than 3 topics" rather than "3 matching topics". What do you think? @KieranMcCann

In T305408#8238771, @Sgs wrote:

Reviewing the designs, I think there's already a "hint" icon for the mode (+ sign). At least in mobile design I can see "GLAM Argentina +", although I think a real examples would show "3 Topics +". Checking on the deployed version it's not showing for me.

From T301825: Account creation: add toggle to enable AND selection of interest topics

Maybe we can fix this bug for mobile and apply the same solution for desktop? One thing that bothers me with "3 Topics +" is that it can be read as "more than 3 topics" rather than "3 matching topics". What do you think? @KieranMcCann

Ah, right. Yeah, it's specific to when there are more than 2 topics selected.

I was thinking that perhaps there is a way to combine the topic icon with a + sign

Hi @kostajh @Sgs. Yep I can see how this is a bit tricky. I don’t think either adding the plus sign to the ‘# topics’ text or to the icon will be particularly clear for users.

I would read ‘3 topics +’ as meaning more than three topics, as you pointed out Sergio.

I’m not sure I would create a new icon for this purpose either, and also I think I would read that as ‘add filters’ rather than representing the filter mode.

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

In T305408#8239180, @KieranMcCann wrote:

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

Characterizing AND/OR relationships is somewhat hard. Does "ALL" mean the tasks must match all three topics, or that we match all tasks that belong in these topics?
Then again, the dropdown is clear so not sure if this view has to be.

In T305408#8243742, @Tgr wrote:

In T305408#8239180, @KieranMcCann wrote:

I wonder if adding the filter mode in parenthesis after the number of topics might be a better solution? Though this may have to be shorted on mobile to fit. Here is what I mean...

Characterizing AND/OR relationships is somewhat hard. Does "ALL" mean the tasks must match all three topics, or that we match all tasks that belong in these topics?
Then again, the dropdown is clear so not sure if this view has to be.

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I’ve mocked up what it would look like to create an icon modifier for the ‘match all’ option and add it to the buttons and drop down. I still have my reservations over whether this makes it clearer but let me know if you think this is better/clearer.

In T305408#8247474, @KieranMcCann wrote:

I agree that the dropdown instructions are clear; perhaps if there was an icon associated with each option in the dropdown in the Topics dialog, and we displayed that icon on the Suggested Edits module next to the topic selection indicator, that would provide enough of a visual cue to the user to remember what is going on with the topics.

I’ve mocked up what it would look like to create an icon modifier for the ‘match all’ option and add it to the buttons and drop down. I still have my reservations over whether this makes it clearer but let me know if you think this is better/clearer.

Thanks. I also have reservations, but it seems better than having no indicator, IMO.

I agree on the fact that it looks better than having no indicator.

As we have a + for ALL, can we have an icon for ANY? ≠ for instance? This way we can reuse it on the task selection card to show which selection was made.

Are we changing the sentences for the filters? If I'm not wrong, at the moment it is

• MediaWiki:Growthexperiments-homepage-suggestededits-topics-match-mode-any ("Match at least one selected topic")
• MediaWiki:Growthexperiments-homepage-suggestededits-topics-match-mode-all ("Match all selected topics").

If we use them, I have some reservations regarding how "Match ANY" and "Match ALL" will look with a longer text and caps, especially on mobile. I use French as an an example, and I built the sentence using source based translators to have something that matches most translations:

• Match ANY -> [Correspond à] N'IMPORTE QUEL terme
• Match ALL -> [Correspond à] TOUS les termes

Brackets are here for parts of the sentence that can be omitted but should be included for clarity. Bu tit is still long for a narrow display.

In terms of the icon I don’t think we should create an additional icon for ANY. As this works in the way you would expect normal filtering to work I would use the standard filter icon for it and then create the modified ‘+’ version for ANY, as this is non-standard filtering. Also ≠ would suggest to me that it meant filter all the terms that do not equal the ones I have selected (i.e. the opposite to what it does).

There is a bit of a process to adding a new icon to the design system icon library. I’ve created a Phab ticket for it: T318597. Will update on progress here.

T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button seems to have stalled out.

In T305408#8243742, @Tgr wrote:

Then again, the dropdown is clear so not sure if this view has to be.

I agree with this view. @KStoller-WMF @RHo Could we consider shipping this without any new icon addition and see how users interact with the feature? The default is "Any" (OR matching). In theory, we could tell from the instrumentation data:

• users who switch to "all" (AND match)
• subset of above users who have no results in the suggested edits feed
• subset of above users who don't interact with suggested edits anymore

We could also consider a "no results" screen that is customized to the scenario where a user has set "all" (AND matching), telling them to switch to "any" (OR) or change their topic filters.

Either way, it would be nice to wrap this one up as it has been lingering for a while.

In T305408#8363025, @kostajh wrote:

T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button seems to have stalled out.

In T305408#8243742, @Tgr wrote:

Then again, the dropdown is clear so not sure if this view has to be.

I agree with this view. @KStoller-WMF @RHo Could we consider shipping this without any new icon addition and see how users interact with the feature? The default is "Any" (OR matching). In theory, we could tell from the instrumentation data:

I've posted an update to T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button to hopefully get it moving. I think it would be preferable to have this minor visual indicator than to have none at all.

• users who switch to "all" (AND match)
• subset of above users who have no results in the suggested edits feed
• subset of above users who don't interact with suggested edits anymore

We could also consider a "no results" screen that is customized to the scenario where a user has set "all" (AND matching), telling them to switch to "any" (OR) or change their topic filters.

This could be another minor improvement to include regardless of whether we have the different icon.

Either way, it would be nice to wrap this one up as it has been lingering for a while.

In T305408#8363567, @RHo wrote:

In T305408#8363025, @kostajh wrote:

T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button seems to have stalled out.

In T305408#8243742, @Tgr wrote:

Then again, the dropdown is clear so not sure if this view has to be.

I agree with this view. @KStoller-WMF @RHo Could we consider shipping this without any new icon addition and see how users interact with the feature? The default is "Any" (OR matching). In theory, we could tell from the instrumentation data:

I've posted an update to T318597: Add icon for new ‘Match ALL’ filtering method to Suggested edits filter button to hopefully get it moving. I think it would be preferable to have this minor visual indicator than to have none at all.

I would rather not block on this so can we add the icon in GrowthExperiments and defer the decision about including it in the Codex icons along with other Growth-specific icons at a later point. Here is SVG icon asset (LTR & RTL):

• users who switch to "all" (AND match)
• subset of above users who have no results in the suggested edits feed
• subset of above users who don't interact with suggested edits anymore

We could also consider a "no results" screen that is customized to the scenario where a user has set "all" (AND matching), telling them to switch to "any" (OR) or change their topic filters.

This could be another minor improvement to include regardless of whether we have the different icon.

I've updated the task T318597 to add the icon on Growth only (not Codex). The SVG is ready for dev but should not be considered a blocker for this work.

Moving to blocked as AIUI this is waiting for T305406: Newcomer tasks: quick analysis of AND selection usage. (Not sure why I moved it the opposite way a month ago, maybe confused it for something else.)

In T305408#8529829, @Tgr wrote:

Moving to blocked as AIUI this is waiting for T305406: Newcomer tasks: quick analysis of AND selection usage. (Not sure why I moved it the opposite way a month ago, maybe confused it for something else.)

I think this task remains blocked but not because of the lack of T305406 analysis which I remember being done by Morten and posted somewhere I can't find now. @nettrom_WMF could you re-post here the quick analysis report? ty!

We should come up with a team consensus on whether to continue scaling this feature or on the other hand roll it back? @RHo @KStoller-WMF

In T305408#8643995, @Sgs wrote:

In T305408#8529829, @Tgr wrote:

Moving to blocked as AIUI this is waiting for T305406: Newcomer tasks: quick analysis of AND selection usage. (Not sure why I moved it the opposite way a month ago, maybe confused it for something else.)

I think this task remains blocked but not because of the lack of T305406 analysis which I remember being done by Morten and posted somewhere I can't find now. @nettrom_WMF could you re-post here the quick analysis report? ty!

We should come up with a team consensus on whether to continue scaling this feature or on the other hand roll it back? @RHo @KStoller-WMF

Hi @Sgs - I think the discussion of not rolling this feature out more widely occurred on T325390 with @KStoller-WMF 's concluding comment:

In T325390#8579460, @KStoller-WMF wrote:

@RHo - it sounds like the conclusion of this task is:
Short term: T326579: Suggested edits topic dialog: Disable save when in AND mode, and no results are found
Long term: work on more extensive filtering improvements: T297117: Newcomer tasks: Provide more granular/advanced topic filtering for people with specific topics. This is work we should consider once we move to Language -agnostic topic classification.
So I think we can consider this task resolved, correct? If you don't agree, feel free to reopen.

I still recommend per comment in T325390#8501191 that we pursue a long-term more considered improvement to filtering on T297117 rather than giving this evidently confusing UI to more people.

In T305408#8644042, @RHo wrote:

Hi @Sgs - I think the discussion of not rolling this feature out more widely occurred on T325390 with @KStoller-WMF 's concluding comment:

I get the plans for improving filtering in general but my question is if we should roll back the feature from the pilot wikis where it is deployed. I would be in favor of a rollback from deployed wikis but keep the code in case there's a campaign event that requires it like it happened with the GLAM in the past. That would save us the burden of maintaining a feature that we're not pushing forward and allow us to allocate resources in T297117 . What do you think @KStoller-WMF @kostajh?

Change 830202 abandoned by Sergio Gimeno:

[operations/mediawiki-config@master] Enable the topic match mode in all wikis

Reason:

Per discussions in T305408 and T325390 the match mode feature is not being scaled to more wikis as it is now.

https://gerrit.wikimedia.org/r/830202

@Sgs I've been torn on making a decision since I think the feature has value, it just needs more work before it's a clear UX win. But since further improvements aren't scheduled on our immediate roadmap, then perhaps a rollback is best. Furthermore, I don't love the practice of leaving a feature deployed at a few wikis that we don't plan to continue to scale.

That being said, a rollback impacts the Growth pilot wikis, so I want to discuss this with Ambassadors next week, and then I'll share my suggestion for how to move forward.

Here's the summary of Ambassador feedback:

• People really want suggested edits to be more personalized and like the idea behind “and” topic filtering, but it's unclear if it's really helping newcomers.
• At smaller wikis, the feature isn't very useful because there aren't enough articles within many topics, so newcomers end up with an empty state often.
• In general, there isn't much discussion about this feature, and we could likely remove it without much impact.

In T305408#8670984, @Sgs wrote:

I would be in favor of a rollback from deployed wikis but keep the code in case there's a campaign event that requires it like it happened with the GLAM in the past. That would save us the burden of maintaining a feature that we're not pushing forward and allow us to allocate resources in T297117 . What do you think @KStoller-WMF @kostajh?

Based on the data gathered, the feedback from Ambassadors, knowing that we don't have time on our immediately roadmap to focus on topic filtering improvements, and knowing that we need to find ways to cut down our maintenance overhead where possible, I'm in favor of this approach.