[go: up one dir, main page]

Page MenuHomePhabricator

Preload story images
Closed, ResolvedPublic

Description

We should allow readers to go back and forth between story pages irrespective of whether an image has been loaded or not. We can use a simple black background for story pages where images are still loading.

  • User land on a first story page, show the image if it's loaded else show a plain background along with a story text.
  • Users are allowed to move back and forth between different story pages.

Event Timeline

SBisson triaged this task as Medium priority.May 11 2022, 12:48 PM
SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.

Change 791082 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Preload images so the viewer does not render a frame without a visible image

https://gerrit.wikimedia.org/r/791082

I'm suggesting the following change in gerrit:

the loading animation only valid for the first image when it's loading, would it makes sense to show loading state when user go to the next frame while it's still loading

that means
1. user land on first frame, first image loaded complete, running for 5 seconds.
2. 5 seconds is over, user on the second frame, the second image still loading and show the loading animation, once loaded complete, 5 seconds start running.

Does it make more sense instead of user hanging on the current image and no loading indicator.

I would suggest that we should allow readers to go back and forth between story pages irrespective of whether an image has been loaded or not. We can use a simple background(black/grey) for story pages where images are still loading.

  • User land on a first story page, show the image if it's loaded else show a plain background along with a story text.
  • Users are allowed to move back and forth between different story pages.

Change 799363 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Show black background until the image is loaded

https://gerrit.wikimedia.org/r/799363

Change 799363 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Show black background until the image is loaded

https://gerrit.wikimedia.org/r/799363

Change 791082 abandoned by Sbisson:

[mediawiki/extensions/Wikistories@master] Preload images

Reason:

Not needed anymore

https://gerrit.wikimedia.org/r/791082

@eamedina Can we close this ticket, since it is not needed anymore?

Testing:

On a slow network, I was able to simulate the black background while an image loads. Cool!

image.png (1×1 px, 264 KB)