[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T304511

"Waiting State" after clicking the submit button
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As a user, I'd like to be aware when the Lexeme creation process is happening, so that I don't try to re-submit the lexeme, when the process is slow.

Acceptance Criteria:

  • When the submit button is clicked and there are no validation errors, The button's text changes to "Creating Lexeme...".

Original Request:

Currently, after the user clicks the submit button, nothing visually happens until either the creation of the Lexeme was successful and the user is redirected there, or there was some error and the user is presented with an error message.

We probably want to somehow communicate to the user: "Please wait, we're processing your request to create a new Lexeme."

(I have no idea about the structure of Design tasks, feel free to reword it as you see fit.)

Notes

  • From Sprint 8 Planning - disabled state for button was pushed for by dev and UX agreed

Details

SubjectRepoBranchLines +/-
Change new lexeme button to “waiting” state after submittingmediawiki/extensions/WikibaseLexememaster+8 -5
Customize query in gerrit

Event Timeline

Michael created this task.Mar 23 2022, 2:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2022, 2:07 PM
Michael added subscribers: Erdinc_Ciftci_WMDE, Lydia_Pintscher.Mar 23 2022, 2:07 PM
Lydia_Pintscher assigned this task to Erdinc_Ciftci_WMDE.Mar 24 2022, 9:47 AM

Erdi: Can you make a suggestion here please?

Lydia_Pintscher added a project: Wikidata Lexicographical data.Mar 24 2022, 9:47 AM
• Sarai-WMDE subscribed.Apr 11 2022, 1:40 PM
Erdinc_Ciftci_WMDE added a comment.Apr 21 2022, 1:14 PM

Considering the new design system work is in progress and we don't have a clear pattern for this case in Wikidata, we can go with indicating through text. That's what happens currently in Item pages when you update an entry.

So basically we change the button text to 'Creating Lexeme...' for the in-progress state.

I've also created a new state in the Figma prototype for reference.

Ps. we don't have to make the button 'disabled' it can visually stay the same but when the user clicks basically nothing happens during this state. The text indicates what's going on clearly anyway.

I can happily answer any question regarding this.

Screenshot 2022-04-21 at 15.09.50.png (820×1 px, 201 KB)

Lydia_Pintscher triaged this task as Medium priority.May 8 2022, 3:43 PM
ItamarWMDE renamed this task from DESIGN - "Waiting State" after clicking the submit button to "Waiting State" after clicking the submit button.May 11 2022, 10:39 AM
ItamarWMDE removed Erdinc_Ciftci_WMDE as the assignee of this task.
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE subscribed.

IMO We would need the disabled state for the button to provide an additional indicator to the lack of behaviour, as well as prevent unnecessary clicks being processed by the browser.

Lydia_Pintscher moved this task from Backlog to milestone x on the Special:NewLexeme revival board.May 11 2022, 10:59 AM
karapayneWMDE updated the task description. (Show Details)May 17 2022, 9:28 AM
karapayneWMDE set the point value for this task to 5.
karapayneWMDE moved this task from milestone x to Special:NewLexeme revival - sprint 8 on the Special:NewLexeme revival board.
karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 8); removed Special:NewLexeme revival.
ItamarWMDE moved this task from To Do to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 18 2022, 8:20 AM
ItamarWMDE added a comment.May 18 2022, 1:20 PM

Task Breakdown Notes:

  • We have decided to implement the disabled button alongside the changed text.
  • We would like to try and test this behaviour with cypress, an optional way to do so is by adding a timeout, for instance.

Potential plan of action:

  1. Add and use a new message 'Creating Lexeme' (by passing it down and using it in the Vue App)
  2. Disable the button while a submit is ongoing
  3. Make sure to reset the submit state when an error occurs
ItamarWMDE moved this task from Parents / Waiting to To Do on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 18 2022, 1:21 PM
Lucas_Werkmeister_WMDE claimed this task.May 23 2022, 12:43 PM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.
Lucas_Werkmeister_WMDE moved this task from Doing to To Do on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 24 2022, 11:58 AM

Main PR (#196) was merged, but we still need a new Wikit (pre)release with #588.

Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 27 2022, 12:25 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 27 2022, 12:36 PM

https://github.com/wmde/wikit/pull/589

Lucas_Werkmeister_WMDE added a comment.May 27 2022, 2:41 PM

https://github.com/wmde/new-lexeme-special-page/pull/197

gerritbot added a comment.May 27 2022, 2:48 PM

Change 800743 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update new-lexeme submodule

https://gerrit.wikimedia.org/r/800743

gerritbot added a project: Patch-For-Review.May 27 2022, 2:48 PM
gerritbot added a comment.May 27 2022, 3:41 PM

Change 800743 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Change new lexeme button to “waiting” state after submitting

https://gerrit.wikimedia.org/r/800743

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.May 27 2022, 3:52 PM

Can be verified on Beta.

One thing I noticed is that the button becomes enabled again, with the original text, when the lexeme has been created and the browser is currently loading the new lexeme. Depending on how fast the wiki responds to the request for the new lexeme page (and perhaps also depending on the browser), the user may still see the form with the re-enabled button for a short while (I saw it for about one second on Beta). We might want to change this.

Lydia_Pintscher closed this task as Resolved.May 30 2022, 4:02 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 8) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits